From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9719724E4D4; Thu, 17 Apr 2025 15:10:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744902657; cv=none; b=lwC/hkPkD26RxmamqeGh+WPOrvo7g0UKUO70+UViAMcQNc/VQdrDedWRlGH1Tx+Yd6SGSNnvKvqdqtmAb1nZdJeeqOQ6rd5uBh12tETa63LmQIYxg5BJ1bk08Rh55JZAGNUqmfTiieoEAMlVkbWJrnqp1gPqzs+EGTlAznw7OcI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744902657; c=relaxed/simple; bh=k9KzxT8RtT8j3vaMkxgHq/WZQBArYVHXFWM5CAfhicI=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=kFudnOeySeKoLQnpsRLerZ9DE9ZSffTqozLu5+pq1IfyHjvZ8G0NUOv0cCqt0jXJq6hFeh9h43o1NXcQdOX4NTKYvfmKXnmwA0mfHd3Hq4XfxlGgSihbCKc7+N88sKgr1bYTNDgnM1UbtPHoAat41wQORzI1FY7CpJxU72XUrb4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qPejttI5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qPejttI5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5A143C4CEE4; Thu, 17 Apr 2025 15:10:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744902657; bh=k9KzxT8RtT8j3vaMkxgHq/WZQBArYVHXFWM5CAfhicI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=qPejttI5AeQmQ210H5IK7GP2nZk1Lu3IhtfKUVo2lfCfjpV+D5LcW9X/KYQ0NX55Z Sd87CLpI0klQQpkfg3OzJv9YpNfxLEuBlXNByX2pe7TkIMWS6El/h9V5OeatNhAtbJ ZOGpfuEsNyUnQ/wYzJDAo8sNKJJUewOglfBsC0kXRIn581ucRmt+OrpaJuLA2ymSRr j6n9DsikYoUnOi/pvSRiYN/aQfP5KZJ4MtW5+tckyPPIGTDLAL3Khsa5ve7cF6IRi9 BXJH1U2/p1lY0AevN2ZKY3l1tklGxf075KWiZ0ejZFtvhaB3J3DgN+YnpNopLDDRXJ 6QjYLxDdQzzDQ== Date: Thu, 17 Apr 2025 08:10:55 -0700 From: Jakub Kicinski To: Daniel Golle Cc: Felix Fietkau , Sean Wang , Lorenzo Bianconi , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH net v2 4/5] net: ethernet: mtk_eth_soc: net: revise NETSYSv3 hardware configuration Message-ID: <20250417081055.1bda2ff6@kernel.org> In-Reply-To: <28929b5bb2bfd45e040a07c0efefb29e57a77513.1744764277.git.daniel@makrotopia.org> References: <8ab7381447e6cdcb317d5b5a6ddd90a1734efcb0.1744764277.git.daniel@makrotopia.org> <28929b5bb2bfd45e040a07c0efefb29e57a77513.1744764277.git.daniel@makrotopia.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 16 Apr 2025 01:51:42 +0100 Daniel Golle wrote: > + /* PSE should not drop port8, port9 and port13 packets from WDMA Tx */ > + mtk_w32(eth, 0x00002300, PSE_DROP_CFG); > + > + /* PSE should drop packets to port8, port9 and port13 on WDMA Rx ring full */ nit: please try to wrap at 80 chars. There's really no need to go over on comments. Some of us stick to 80 char terminals. > + mtk_w32(eth, 0x00002300, PSE_PPE_DROP(0)); > + mtk_w32(eth, 0x00002300, PSE_PPE_DROP(1)); > + mtk_w32(eth, 0x00002300, PSE_PPE_DROP(2)); > > /* GDM and CDM Threshold */ > - mtk_w32(eth, 0x00000707, MTK_CDMW0_THRES); > + mtk_w32(eth, 0x08000707, MTK_CDMW0_THRES); > mtk_w32(eth, 0x00000077, MTK_CDMW1_THRES); > > /* Disable GDM1 RX CRC stripping */ > @@ -4064,7 +4076,7 @@ static int mtk_hw_init(struct mtk_eth *eth, bool reset) > mtk_w32(eth, 0x00000300, PSE_DROP_CFG); > > /* PSE should drop packets to port 8/9 on WDMA Rx ring full */ > - mtk_w32(eth, 0x00000300, PSE_PPE0_DROP); > + mtk_w32(eth, 0x00000300, PSE_PPE_DROP(0)); > > /* PSE Free Queue Flow Control */ > mtk_w32(eth, 0x01fa01f4, PSE_FQFC_CFG2); > diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.h b/drivers/net/ethernet/mediatek/mtk_eth_soc.h > index 39709649ea8d1..eaa96c8483b70 100644 > --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.h > +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.h > @@ -151,7 +151,12 @@ > #define PSE_FQFC_CFG1 0x100 > #define PSE_FQFC_CFG2 0x104 > #define PSE_DROP_CFG 0x108 > -#define PSE_PPE0_DROP 0x110 > +#define PSE_PPE_DROP(x) (0x110 + ((x) * 0x4)) > + > +/* PSE Last FreeQ Page Request Control */ > +#define PSE_DUMY_REQ 0x10C This really looks like misspelling of DUMMY, is it really supposed to have one 'M' ?