From: Jakub Kicinski <kuba@kernel.org>
To: Jiawen Wu <jiawenwu@trustnetic.com>
Cc: netdev@vger.kernel.org, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
horms@kernel.org, dlemoal@kernel.org, jdamato@fastly.com,
saikrishnag@marvell.com, vadim.fedorenko@linux.dev,
przemyslaw.kitszel@intel.com, ecree.xilinx@gmail.com,
rmk+kernel@armlinux.org.uk, mengyuanlou@net-swift.com
Subject: Re: [PATCH net-next v3 1/2] net: txgbe: Support to set UDP tunnel port
Date: Thu, 17 Apr 2025 16:57:36 -0700 [thread overview]
Message-ID: <20250417165736.15d212ec@kernel.org> (raw)
In-Reply-To: <20250417080328.426554-2-jiawenwu@trustnetic.com>
On Thu, 17 Apr 2025 16:03:27 +0800 Jiawen Wu wrote:
> @@ -392,6 +393,8 @@ static int txgbe_open(struct net_device *netdev)
^^^^^^^^^^
>
> txgbe_up_complete(wx);
>
> + udp_tunnel_nic_reset_ntf(netdev);
^^^^^^^^^^^^^^^^^^^^^^^^
> return 0;
> + .flags = UDP_TUNNEL_NIC_INFO_OPEN_ONLY,
Documentation says:
/* Device only supports offloads when it's open, all ports
* will be removed before close and re-added after open.
*/
UDP_TUNNEL_NIC_INFO_OPEN_ONLY = BIT(1),
Are you sure you have to explicitly reset?
next prev parent reply other threads:[~2025-04-17 23:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-17 8:03 [PATCH net-next v3 0/2] Implement udp tunnel port for txgbe Jiawen Wu
2025-04-17 8:03 ` [PATCH net-next v3 1/2] net: txgbe: Support to set UDP tunnel port Jiawen Wu
2025-04-17 23:57 ` Jakub Kicinski [this message]
2025-04-18 1:44 ` Jiawen Wu
2025-04-18 2:19 ` Jakub Kicinski
2025-04-18 2:36 ` Jiawen Wu
2025-04-17 8:03 ` [PATCH net-next v3 2/2] net: wangxun: restrict feature flags for tunnel packets Jiawen Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250417165736.15d212ec@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dlemoal@kernel.org \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jdamato@fastly.com \
--cc=jiawenwu@trustnetic.com \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=saikrishnag@marvell.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).