From: Jakub Kicinski <kuba@kernel.org>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: Sathesh B Edara <sedara@marvell.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <hgani@marvell.com>,
<vimleshk@marvell.com>, Veerasenareddy Burru <vburru@marvell.com>,
Shinas Rasheed <srasheed@marvell.com>,
Satananda Burla <sburla@marvell.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net v3] octeon_ep_vf: Resolve netdevice usage count issue
Date: Thu, 17 Apr 2025 19:25:47 -0700 [thread overview]
Message-ID: <20250417192547.36a7503e@kernel.org> (raw)
In-Reply-To: <07549649-3712-47b9-917b-c5001f9761cb@intel.com>
On Wed, 16 Apr 2025 13:26:43 -0700 Jacob Keller wrote:
> > @@ -834,7 +833,6 @@ static void octep_vf_tx_timeout(struct net_device *netdev, unsigned int txqueue)
> > {
> > struct octep_vf_device *oct = netdev_priv(netdev);
> >
> > - netdev_hold(netdev, NULL, GFP_ATOMIC);
> > schedule_work(&oct->tx_timeout_task);
> > }
> I guess the thought was that we need to hold because we scheduled a work
> item?
Looks like something I would have asked them to do :)
But it was probably merged before I could review next version ?
I mean, passing NULL for the tracker is... quite something.
> Presumably the driver would simply cancel_work_sync() on this timeout
> task before it attempts to release its own reference on the netdev, so
> this really doesn't protect anything.
It does, but before unregistering :/
Sathesh, schedule_work() returns a value. You should use it.
prev parent reply other threads:[~2025-04-18 2:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-16 10:25 [PATCH net v3] octeon_ep_vf: Resolve netdevice usage count issue Sathesh B Edara
2025-04-16 20:26 ` Jacob Keller
2025-04-18 2:25 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250417192547.36a7503e@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hgani@marvell.com \
--cc=jacob.e.keller@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sburla@marvell.com \
--cc=sedara@marvell.com \
--cc=srasheed@marvell.com \
--cc=vburru@marvell.com \
--cc=vimleshk@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).