From: Jakub Kicinski <kuba@kernel.org>
To: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Cc: "Ваторопин Андрей" <a.vatoropin@crpt.ru>,
"Ajit Khaparde" <ajit.khaparde@broadcom.com>,
"Sriharsha Basavapatna" <sriharsha.basavapatna@broadcom.com>,
"Somnath Kotur" <somnath.kotur@broadcom.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Padmanabh Ratnakar" <padmanabh.ratnakar@emulex.com>,
"Mammatha Edhala" <mammatha.edhala@emulex.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lvc-project@linuxtesting.org" <lvc-project@linuxtesting.org>
Subject: Re: [PATCH] be2net: Remove potential access to the zero address
Date: Thu, 17 Apr 2025 19:54:53 -0700 [thread overview]
Message-ID: <20250417195453.2f3260aa@kernel.org> (raw)
In-Reply-To: <Z/+VTcHpQMJ3ioCM@mev-dev.igk.intel.com>
On Wed, 16 Apr 2025 13:32:29 +0200 Michal Swiatkowski wrote:
> > At the moment of calling the function be_cmd_get_mac_from_list() with the
> > following parameters:
> > be_cmd_get_mac_from_list(adapter, mac, &pmac_valid, NULL,
> > adapter->if_handle, 0);
>
> Looks like pmac_valid needs to be false to reach *pmac_id assign.
Right, it is for this caller and there is a check which skip this logic
if pmac_id_valid is false, line 3738.
next prev parent reply other threads:[~2025-04-18 2:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-16 10:55 [PATCH] be2net: Remove potential access to the zero address Ваторопин Андрей
2025-04-16 11:32 ` Michal Swiatkowski
2025-04-18 2:54 ` Jakub Kicinski [this message]
2025-04-18 7:50 ` Fedor Pchelkin
2025-04-19 0:15 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250417195453.2f3260aa@kernel.org \
--to=kuba@kernel.org \
--cc=a.vatoropin@crpt.ru \
--cc=ajit.khaparde@broadcom.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=mammatha.edhala@emulex.com \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=padmanabh.ratnakar@emulex.com \
--cc=somnath.kotur@broadcom.com \
--cc=sriharsha.basavapatna@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).