netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net, donald.hunter@gmail.com
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
	andrew+netdev@lunn.ch, horms@kernel.org,
	Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH net-next 02/12] netlink: specs: rt-link: remove the fixed members from attrs
Date: Thu, 17 Apr 2025 19:16:56 -0700	[thread overview]
Message-ID: <20250418021706.1967583-3-kuba@kernel.org> (raw)
In-Reply-To: <20250418021706.1967583-1-kuba@kernel.org>

The purpose of the attribute list is to list the attributes
which will be included in a given message to shrink the objects
for families with huge attr spaces. Fixed headers are always
present in their entirety (between netlink header and the attrs)
so there's no point in listing their members. Current C codegen
doesn't expect them and tries to look them up in the attribute space.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
 Documentation/netlink/specs/rt-link.yaml | 13 -------------
 1 file changed, 13 deletions(-)

diff --git a/Documentation/netlink/specs/rt-link.yaml b/Documentation/netlink/specs/rt-link.yaml
index 726dfa083d14..cb7bacbd3d95 100644
--- a/Documentation/netlink/specs/rt-link.yaml
+++ b/Documentation/netlink/specs/rt-link.yaml
@@ -2367,7 +2367,6 @@ protonum: 0
         request:
           value: 16
           attributes: &link-new-attrs
-            - ifi-index
             - ifname
             - net-ns-pid
             - net-ns-fd
@@ -2399,7 +2398,6 @@ protonum: 0
         request:
           value: 17
           attributes:
-            - ifi-index
             - ifname
     -
       name: getlink
@@ -2410,7 +2408,6 @@ protonum: 0
         request:
           value: 18
           attributes:
-            - ifi-index
             - ifname
             - alt-ifname
             - ext-mask
@@ -2418,11 +2415,6 @@ protonum: 0
         reply:
           value: 16
           attributes: &link-all-attrs
-            - ifi-family
-            - ifi-type
-            - ifi-index
-            - ifi-flags
-            - ifi-change
             - address
             - broadcast
             - ifname
@@ -2515,14 +2507,9 @@ protonum: 0
       do:
         request:
           value: 94
-          attributes:
-            - ifindex
         reply:
           value: 92
           attributes: &link-stats-attrs
-            - family
-            - ifindex
-            - filter-mask
             - link-64
             - link-xstats
             - link-xstats-slave
-- 
2.49.0


  parent reply	other threads:[~2025-04-18  2:17 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-18  2:16 [PATCH net-next 00/12] netlink: specs: rtnetlink: adjust specs for C codegen Jakub Kicinski
2025-04-18  2:16 ` [PATCH net-next 01/12] netlink: specs: allow header properties for attribute sets Jakub Kicinski
2025-04-18 10:20   ` Donald Hunter
2025-04-18  2:16 ` Jakub Kicinski [this message]
2025-04-18 10:27   ` [PATCH net-next 02/12] netlink: specs: rt-link: remove the fixed members from attrs Donald Hunter
2025-04-18  2:16 ` [PATCH net-next 03/12] netlink: specs: rt-link: remove if-netnsid from attr list Jakub Kicinski
2025-04-18 10:31   ` Donald Hunter
2025-04-18  2:16 ` [PATCH net-next 04/12] netlink: specs: rt-link: remove duplicated group in " Jakub Kicinski
2025-04-18 10:32   ` Donald Hunter
2025-04-18  2:16 ` [PATCH net-next 05/12] netlink: specs: rt-link: add C naming info Jakub Kicinski
2025-04-18 10:36   ` Donald Hunter
2025-04-18  2:17 ` [PATCH net-next 06/12] netlink: specs: rt-link: adjust AF_ nest for C codegen Jakub Kicinski
2025-04-18 10:39   ` Donald Hunter
2025-04-18  2:17 ` [PATCH net-next 07/12] netlink: specs: rt-link: make bond's ipv6 address attribute fixed size Jakub Kicinski
2025-04-18 10:39   ` Donald Hunter
2025-04-18  2:17 ` [PATCH net-next 08/12] netlink: specs: rt-link: add notification for newlink Jakub Kicinski
2025-04-18 10:41   ` Donald Hunter
2025-04-18  2:17 ` [PATCH net-next 09/12] netlink: specs: rt-neigh: add C naming info Jakub Kicinski
2025-04-18 10:42   ` Donald Hunter
2025-04-18  2:17 ` [PATCH net-next 10/12] netlink: specs: rt-neigh: make sure getneigh is consistent Jakub Kicinski
2025-04-18 10:45   ` Donald Hunter
2025-04-18  2:17 ` [PATCH net-next 11/12] netlink: specs: rtnetlink: correct notify properties Jakub Kicinski
2025-04-18 10:46   ` Donald Hunter
2025-04-18  2:17 ` [PATCH net-next 12/12] netlink: specs: rt-rule: add C naming info Jakub Kicinski
2025-04-18 10:46   ` Donald Hunter
2025-04-23 23:20 ` [PATCH net-next 00/12] netlink: specs: rtnetlink: adjust specs for C codegen patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250418021706.1967583-3-kuba@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=donald.hunter@gmail.com \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).