From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07F1B2405FD for ; Fri, 18 Apr 2025 20:49:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745009382; cv=none; b=Xd+TFdW/Pn5vytJbsMQuQjVTyZa4K1GQY3a4EMetqQ4AXFG1hzK6igHoYeTrjyqblvUVbQL/dApwMlJ46hGV34tv6bCIe1VcRF8sXYRRZGyozHzOJ9LqAk7tmBLp+TqZRR66YA+ESrnv5JsfPVkdynf2t7CdI9Oj2p/BMwxtTMM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745009382; c=relaxed/simple; bh=cZl/BJfi/h+kCCJwfmS9oToj6j7Cv1nicnQuhsqPm2Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=prIQsWzawXh9WKTL/4kmhA+XMlBUOYJgvixGIEreJQjkd/7vAd0UeQ/AtLvfQozqqgPnrk8S6QSrEdezlDh1rEcIpKnHUIQsxo0pl494oKPiGBKX7yrIfPsVLUxPlpKQCd6wRL8ozJLGW7lf7jdgGyzcgDKYWwwbUeseJy5x1PI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=foaSQ+Hu; arc=none smtp.client-ip=192.198.163.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="foaSQ+Hu" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1745009381; x=1776545381; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=cZl/BJfi/h+kCCJwfmS9oToj6j7Cv1nicnQuhsqPm2Y=; b=foaSQ+Hu/ivFpM0EkTmAtb8+gxO8wMtyaoWFzvUaj6539lQiGyPEq03F N7j2mx3DBYai6NEo/zNe04jUhwyD5hv/6J/PDYqhER+0m1FCxvYqILL0Y jm+qoT00BHvwJsQkuygxgkSXLw+2mPNgcr1wnPyZypULw28llJ5CbhaF8 qKUSCxQLpxJwUs31g+CS/uRJWmgosssliPKE2EUAjWbX6KyigAPvyFwcK zfcmUMekNyaoduIC9WOtiv61T5lTOC/PkmyyVZMBP7ujzXaAQTC49R4PL 9RkM1EuPYGYZ7hsV3Ym5WVOd8X9yZtKRdtTJLG1I0xoh+m+1oADRYI2px w==; X-CSE-ConnectionGUID: XOuO0cY0TyiUX5WgZ/+++w== X-CSE-MsgGUID: jTyypI6QTvKyoC92zIa/Xg== X-IronPort-AV: E=McAfee;i="6700,10204,11407"; a="46814321" X-IronPort-AV: E=Sophos;i="6.15,222,1739865600"; d="scan'208";a="46814321" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Apr 2025 13:49:37 -0700 X-CSE-ConnectionGUID: EINdv4ZuQJ6s2OojfH7jFw== X-CSE-MsgGUID: Z5RygqyGRHigDe7nsR5cdQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,222,1739865600"; d="scan'208";a="168406316" Received: from unknown (HELO localhost.jf.intel.com) ([10.166.80.55]) by orviesa001.jf.intel.com with ESMTP; 18 Apr 2025 13:49:36 -0700 From: Pavan Kumar Linga To: intel-wired-lan@lists.osuosl.org Cc: netdev@vger.kernel.org, milena.olech@intel.com, anton.nadezhdin@intel.com, Pavan Kumar Linga Subject: [PATCH iwl-next v2 5/9] idpf: reshuffle idpf_vport struct members to avoid holes Date: Fri, 18 Apr 2025 13:49:15 -0700 Message-ID: <20250418204919.5875-6-pavan.kumar.linga@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250418204919.5875-1-pavan.kumar.linga@intel.com> References: <20250418204919.5875-1-pavan.kumar.linga@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The previous refactor of moving queue and vector resources out of the idpf_vport structure, created few holes. Reshuffle the existing members to avoid holes as much as possible. Reviewed-by: Anton Nadezhdin Signed-off-by: Pavan Kumar Linga --- drivers/net/ethernet/intel/idpf/idpf.h | 27 +++++++++++++------------- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/drivers/net/ethernet/intel/idpf/idpf.h b/drivers/net/ethernet/intel/idpf/idpf.h index bd95947a9936..39f4c7009a1a 100644 --- a/drivers/net/ethernet/intel/idpf/idpf.h +++ b/drivers/net/ethernet/intel/idpf/idpf.h @@ -319,24 +319,24 @@ struct idpf_q_vec_rsrc { /** * struct idpf_vport - Handle for netdevices and queue resources * @dflt_qv_rsrc: contains default queue and vector resources - * @num_txq: Number of allocated TX queues - * @compln_clean_budget: Work budget for completion clean * @txqs: Used only in hotpath to get to the right queue very fast - * @crc_enable: Enable CRC insertion offload - * @rx_ptype_lkup: Lookup table for ptypes on RX * @adapter: back pointer to associated adapter * @netdev: Associated net_device. Each vport should have one and only one * associated netdev. * @flags: See enum idpf_vport_flags - * @vport_type: Default SRIOV, SIOV, etc. + * @compln_clean_budget: Work budget for completion clean * @vport_id: Device given vport identifier + * @vport_type: Default SRIOV, SIOV, etc. * @idx: Software index in adapter vports struct - * @default_vport: Use this vport if one isn't specified + * @num_txq: Number of allocated TX queues * @max_mtu: device given max possible MTU * @default_mac_addr: device will give a default MAC to use * @rx_itr_profile: RX profiles for Dynamic Interrupt Moderation * @tx_itr_profile: TX profiles for Dynamic Interrupt Moderation + * @rx_ptype_lkup: Lookup table for ptypes on RX * @port_stats: per port csum, header split, and other offload stats + * @default_vport: Use this vport if one isn't specified + * @crc_enable: Enable CRC insertion offload * @link_up: True if link is up * @sw_marker_wq: workqueue for marker packets * @tx_tstamp_caps: Capabilities negotiated for Tx timestamping @@ -346,27 +346,26 @@ struct idpf_q_vec_rsrc { */ struct idpf_vport { struct idpf_q_vec_rsrc dflt_qv_rsrc; - u16 num_txq; - u32 compln_clean_budget; struct idpf_tx_queue **txqs; - bool crc_enable; - - struct libeth_rx_pt *rx_ptype_lkup; struct idpf_adapter *adapter; struct net_device *netdev; DECLARE_BITMAP(flags, IDPF_VPORT_FLAGS_NBITS); - u16 vport_type; + u32 compln_clean_budget; u32 vport_id; + u16 vport_type; u16 idx; - bool default_vport; + u16 num_txq; u16 max_mtu; u8 default_mac_addr[ETH_ALEN]; u16 rx_itr_profile[IDPF_DIM_PROFILE_SLOTS]; u16 tx_itr_profile[IDPF_DIM_PROFILE_SLOTS]; - struct idpf_port_stats port_stats; + struct libeth_rx_pt *rx_ptype_lkup; + struct idpf_port_stats port_stats; + bool default_vport; + bool crc_enable; bool link_up; wait_queue_head_t sw_marker_wq; -- 2.43.0