netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Cindy Lu <lulu@redhat.com>
To: lulu@redhat.com, jasowang@redhat.com, mst@redhat.com,
	michael.christie@oracle.com, sgarzare@redhat.com,
	linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	netdev@vger.kernel.org
Subject: [PATCH v9 1/4] vhost: Add a new parameter in vhost_dev to allow user select kthread
Date: Mon, 21 Apr 2025 10:44:07 +0800	[thread overview]
Message-ID: <20250421024457.112163-2-lulu@redhat.com> (raw)
In-Reply-To: <20250421024457.112163-1-lulu@redhat.com>

The vhost now uses vhost_task and workers as a child of the owner thread.
While this aligns with containerization principles, it confuses some
legacy userspace applications, therefore, we are reintroducing kthread
API support.

Introduce a new parameter to enable users to choose between kthread and
task mode.

By default, this parameter is set to true, so the default behavior
remains unchanged by this patch.

Signed-off-by: Cindy Lu <lulu@redhat.com>
---
 drivers/vhost/vhost.c | 1 +
 drivers/vhost/vhost.h | 9 +++++++++
 2 files changed, 10 insertions(+)

diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index 63612faeab72..250dc43f1786 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
@@ -552,6 +552,7 @@ void vhost_dev_init(struct vhost_dev *dev,
 	dev->byte_weight = byte_weight;
 	dev->use_worker = use_worker;
 	dev->msg_handler = msg_handler;
+	dev->inherit_owner = true;
 	init_waitqueue_head(&dev->wait);
 	INIT_LIST_HEAD(&dev->read_list);
 	INIT_LIST_HEAD(&dev->pending_list);
diff --git a/drivers/vhost/vhost.h b/drivers/vhost/vhost.h
index bb75a292d50c..19bb94922a0e 100644
--- a/drivers/vhost/vhost.h
+++ b/drivers/vhost/vhost.h
@@ -176,6 +176,15 @@ struct vhost_dev {
 	int byte_weight;
 	struct xarray worker_xa;
 	bool use_worker;
+	/*
+	 * If inherit_owner is true we use vhost_tasks to create
+	 * the worker so all settings/limits like cgroups, NPROC,
+	 * scheduler, etc are inherited from the owner. If false,
+	 * we use kthreads and only attach to the same cgroups
+	 * as the owner for compat with older kernels.
+	 * here we use true as default value
+	 */
+	bool inherit_owner;
 	int (*msg_handler)(struct vhost_dev *dev, u32 asid,
 			   struct vhost_iotlb_msg *msg);
 };
-- 
2.45.0


  reply	other threads:[~2025-04-21  2:45 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-21  2:44 [PATCH v9 0/4] vhost: Add support of kthread API Cindy Lu
2025-04-21  2:44 ` Cindy Lu [this message]
2025-04-21  3:25   ` [PATCH v9 1/4] vhost: Add a new parameter in vhost_dev to allow user select kthread Jason Wang
2025-04-22 13:36   ` Stefano Garzarella
2025-04-21  2:44 ` [PATCH v9 2/4] vhost: Reintroduce kthread mode support in vhost Cindy Lu
2025-04-21  3:39   ` Jason Wang
2025-04-21 10:59     ` Michael S. Tsirkin
2025-04-21 10:58   ` Michael S. Tsirkin
2025-04-21  2:44 ` [PATCH v9 3/4] vhost: add VHOST_FORK_FROM_OWNER ioctl and validate inherit_owner Cindy Lu
2025-04-21  3:40   ` Jason Wang
2025-04-22 13:45   ` Stefano Garzarella
2025-04-21  2:44 ` [PATCH v9 4/4] vhost: Add a KConfig knob to enable IOCTL VHOST_FORK_FROM_OWNER Cindy Lu
2025-04-21  3:45   ` Jason Wang
2025-04-21  3:46     ` Jason Wang
2025-04-29  3:39       ` Jason Wang
2025-04-29 10:55         ` Michael S. Tsirkin
2025-04-30  3:34           ` Jason Wang
2025-04-30  9:27             ` Michael S. Tsirkin
2025-05-13  4:08               ` Jason Wang
2025-05-13  7:08                 ` Michael S. Tsirkin
2025-05-14  2:52                   ` Jason Wang
2025-05-15  6:05                     ` Cindy Lu
2025-05-15  6:14                     ` Michael S. Tsirkin
2025-05-16  1:31                       ` Jason Wang
2025-05-16 10:39                         ` Michael S. Tsirkin
2025-05-19  7:34                           ` Jason Wang
2025-04-22 13:50   ` Stefano Garzarella
2025-04-23  1:01     ` Cindy Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250421024457.112163-2-lulu@redhat.com \
    --to=lulu@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.christie@oracle.com \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=sgarzare@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).