Re: [PATCH net-next v1 2/3] dpll: add reference sync get/set

[Simon Horman <horms@kernel.org>]

On Tue, Apr 15, 2025 at 07:51:14PM +0200, Arkadiusz Kubalewski wrote:
> Define function for reference sync pin registration and callback ops to
> set/get current feature state.
> 
> Implement netlink handler to fill netlink messages with reference sync
> pin configuration of capable pins (pin-get).
> 
> Implement netlink handler to call proper ops and configure reference
> sync pin state (pin-set).
> 
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Reviewed-by: Milena Olech <milena.olech@intel.com>
> Signed-off-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>

...

> diff --git a/drivers/dpll/dpll_core.h b/drivers/dpll/dpll_core.h
> index 2b6d8ef1cdf3..b77e021356ca 100644
> --- a/drivers/dpll/dpll_core.h
> +++ b/drivers/dpll/dpll_core.h
> @@ -56,6 +56,7 @@ struct dpll_pin {
>  	struct module *module;
>  	struct xarray dpll_refs;
>  	struct xarray parent_refs;
> +	struct xarray sync_pins;

nit: Please add sync_pins to the Kernel doc for struct dpll_pin.

     And, separately, it would be quite nice if documentation
     of the non-existent rclk_dev_name member removed too.

>  	struct dpll_pin_properties prop;
>  	refcount_t refcount;
>  	struct rcu_head rcu;

...