From: Simon Horman <horms@kernel.org>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org,
Maxime Chevallier <maxime.chevallier@bootlin.com>
Subject: Re: [PATCH net-next v1 1/4] net: selftests: drop test index from net_selftest_get_strings()
Date: Mon, 21 Apr 2025 15:33:25 +0100 [thread overview]
Message-ID: <20250421143325.GM2789685@horms.kernel.org> (raw)
In-Reply-To: <20250416161439.2922994-2-o.rempel@pengutronix.de>
On Wed, Apr 16, 2025 at 06:14:36PM +0200, Oleksij Rempel wrote:
> The test index is redundant and reduces available space for test names,
> which are already limited to ETH_GSTRING_LEN (32 bytes). Removing the
> index improves readability in tools like `ethtool -t`, especially when
> longer test names are used.
>
> Before this change:
> 3. PHY internal loopback, enab
> 7. PHY internal loopback, disa
>
> After this change:
> PHY internal loopback, enable
> PHY internal loopback, disable
>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-04-21 14:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-16 16:14 [PATCH net-next v1 0/4] net: selftest: improve test string formatting and checksum handling Oleksij Rempel
2025-04-16 16:14 ` [PATCH net-next v1 1/4] net: selftests: drop test index from net_selftest_get_strings() Oleksij Rempel
2025-04-21 14:33 ` Simon Horman [this message]
2025-04-16 16:14 ` [PATCH net-next v1 2/4] net: selftest: prepare for detailed error handling in net_test_get_skb() Oleksij Rempel
2025-04-21 14:33 ` Simon Horman
2025-04-16 16:14 ` [PATCH net-next v1 3/4] net: selftest: add checksum mode support and SW checksum handling Oleksij Rempel
2025-04-21 14:32 ` Simon Horman
2025-04-16 16:14 ` [PATCH net-next v1 4/4] net: selftest: add PHY loopback tests with HW checksum offload Oleksij Rempel
2025-04-21 14:33 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250421143325.GM2789685@horms.kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).