From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 055E1134BD for ; Tue, 22 Apr 2025 01:36:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745285772; cv=none; b=qYRmV8nQ4R0xuG1rBtmvQgEoOCKvTN834gsRK2Pt4Vm8ldhscZABlO4yYOM3SigTpcjrsW+aFmVcu67/GWdHNrsIVe6wSA72YtihyRsNefO9q5Lf7d8izagQdsD2qumX1cOWMGqEux3361T4EjLdQ90kBMT2Kgo2xTW/ATm+ygE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745285772; c=relaxed/simple; bh=jaSaaz4fD7gmy5u/L+9Ywg1JbN6BK11zXKoZ4GqzkRg=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=DLDwn/60B49nzL21pRpUCZFj3KX1kQxNXzAMhUGX4dyl60V+x6+Ayat+OA2skSkAjrwWrfIbQFCs/MBE4yvFSZf+hIWtfg/5f1gwv3IBZX42/49lVFFB8rRLPakNuuA8buVc9RY59zE0CNlf8d48q2NdWNP0vly4kiBfnmWgPXY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gYQau24O; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gYQau24O" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1A678C4CEE4; Tue, 22 Apr 2025 01:36:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1745285771; bh=jaSaaz4fD7gmy5u/L+9Ywg1JbN6BK11zXKoZ4GqzkRg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=gYQau24O5eGvmuufDN0rW0XBs9GPjVVDtpPYw/mZeJsyIofS5cjPRsvIhuiwoO3R9 B3k6pTHPt0XMREAyEL1xd1ZuOLIObVNsgF9vgDzFu3VzvB3WZuY50qo9blGBwBM+8+ FQpN8Hy/a6+wIkf/xMN4YI0QNg/VQb12oOJLk8E/cAyhJpyqx0ZGJdGF7xJ5fgN5VS zxwWDsX7xCRIKCJocSEOYiDXm16TunVszZc6rZE2VcPkkp84Nit+meTPkrajJ42XGd j3EgOGeCn/Ufuwgq8uWWXckstGmlqVZZQQ9tmEm2n8gTuv1LAar7ei9DkWPSS4kDa/ v7ZVSYrH7o9hA== Date: Mon, 21 Apr 2025 18:36:10 -0700 From: Jakub Kicinski To: Lorenzo Bianconi Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, netdev@vger.kernel.org, Simon Horman Subject: Re: [PATCH net-next v2] net: airoha: Add missing filed to ppe_mbox_data struct Message-ID: <20250421183610.7bad877c@kernel.org> In-Reply-To: <20250417-airoha-en7581-fix-ppe_mbox_data-v2-1-43433cfbe874@kernel.org> References: <20250417-airoha-en7581-fix-ppe_mbox_data-v2-1-43433cfbe874@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 17 Apr 2025 11:30:47 +0200 Lorenzo Bianconi wrote: > The official Airoha EN7581 firmware requires adding max_packet filed in > ppe_mbox_data struct while the unofficial one used to develop the Airoha > EN7581 flowtable support does not require this field. > This patch does not introduce any real backwards compatible issue since > EN7581 fw is not publicly available in linux-firmware or other > repositories (e.g. OpenWrt) yet and the official fw version will use this > new layout. For this reason this change needs to be backported. > > Fixes: 23290c7bc190d ("net: airoha: Introduce Airoha NPU support") I'm not sure I agree with this fixes tag. The fixes tag should point to the earliest commit where any problem may be visible. IIUC you're targeting net-next because the structure is not used in net. So the Fixes tag should also point to some commit in net-next... If we leave it as is after the merge window stable bot will pull this commit into 6.15 for no good reason. -- pw-bot: cr