Re: [PATCH net-next 3/5] net: bcmasp: Remove support for asp-v2.0

[Simon Horman <horms@kernel.org>]

On Wed, Apr 16, 2025 at 03:48:13PM -0700, Justin Chen wrote:
> The SoC that supported asp-v2.0 never saw the light of day. asp-v2.0 has
> quirks that makes the logic overly complicated. For example, asp-v2.0 is
> the only revision that has a different wake up IRQ hook up. Remove asp-v2.0
> support to make supporting future HW revisions cleaner.
> 
> Signed-off-by: Justin Chen <justin.chen@broadcom.com>
> ---
>  drivers/net/ethernet/broadcom/asp2/bcmasp.c   | 98 ++-----------------
>  drivers/net/ethernet/broadcom/asp2/bcmasp.h   | 45 ++-------
>  .../ethernet/broadcom/asp2/bcmasp_ethtool.c   | 21 +---
>  .../net/ethernet/broadcom/asp2/bcmasp_intf.c  |  2 +-
>  .../ethernet/broadcom/asp2/bcmasp_intf_defs.h |  3 +-
>  5 files changed, 23 insertions(+), 146 deletions(-)
> 
> diff --git a/drivers/net/ethernet/broadcom/asp2/bcmasp.c b/drivers/net/ethernet/broadcom/asp2/bcmasp.c

...

>  static const struct bcmasp_plat_data v21_plat_data = {
> -	.init_wol = bcmasp_init_wol_shared,
> -	.enable_wol = bcmasp_enable_wol_shared,
> -	.destroy_wol = bcmasp_wol_irq_destroy_shared,
>  	.core_clock_select = bcmasp_core_clock_select_one,
> -	.hw_info = &v21_hw_info,
> +	.eee_fixup = NULL;

	.eee_fixup = NULL,

>  };

...