From: Jakub Kicinski <kuba@kernel.org>
To: Vadim Fedorenko <vadfed@meta.com>
Cc: Michael Chan <michael.chan@broadcom.com>,
Pavan Chebbi <pavan.chebbi@broadcom.com>,
Vadim Fedorenko <vadim.fedorenko@linux.dev>,
Richard Cochran <richardcochran@gmail.com>,
<netdev@vger.kernel.org>
Subject: Re: [PATCH net v2] bnxt_en: improve TX timestamping FIFO configuration
Date: Tue, 22 Apr 2025 18:51:09 -0700 [thread overview]
Message-ID: <20250422185109.0813346f@kernel.org> (raw)
In-Reply-To: <20250417160141.4091537-1-vadfed@meta.com>
On Thu, 17 Apr 2025 09:01:41 -0700 Vadim Fedorenko wrote:
> @@ -1117,12 +1138,5 @@ void bnxt_ptp_clear(struct bnxt *bp)
> kfree(ptp->ptp_info.pin_config);
> ptp->ptp_info.pin_config = NULL;
>
> - for (i = 0; i < BNXT_MAX_TX_TS; i++) {
> - if (ptp->txts_req[i].tx_skb) {
> - dev_kfree_skb_any(ptp->txts_req[i].tx_skb);
> - ptp->txts_req[i].tx_skb = NULL;
> - }
> - }
> -
> bnxt_unmap_ptp_regs(bp);
drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c:1129:6: warning: unused variable 'i' [-Wunused-variable]
1129 | int i;
| ^
--
pw-bot: cr
prev parent reply other threads:[~2025-04-23 1:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-17 16:01 [PATCH net v2] bnxt_en: improve TX timestamping FIFO configuration Vadim Fedorenko
2025-04-17 17:01 ` Michael Chan
2025-04-21 9:38 ` Pavan Chebbi
2025-04-21 17:35 ` Michael Chan
2025-04-23 1:51 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250422185109.0813346f@kernel.org \
--to=kuba@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pavan.chebbi@broadcom.com \
--cc=richardcochran@gmail.com \
--cc=vadfed@meta.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).