From: Jakub Kicinski <kuba@kernel.org>
To: Johannes Schneider <johannes.schneider@leica-geosystems.com>
Cc: dmurphy@ti.com, andrew@lunn.ch, davem@davemloft.net,
f.fainelli@gmail.com, hkallweit1@gmail.com,
linux-kernel@vger.kernel.org, linux@armlinux.org.uk,
michael@walle.cc, netdev@vger.kernel.org,
bsp-development.geo@leica-geosystems.com
Subject: Re: [PATCH net v2] net: dp83822: Fix OF_MDIO config check
Date: Tue, 22 Apr 2025 19:56:55 -0700 [thread overview]
Message-ID: <20250422195655.78124fab@kernel.org> (raw)
In-Reply-To: <20250422090634.4145880-1-johannes.schneider@leica-geosystems.com>
On Tue, 22 Apr 2025 11:06:34 +0200 Johannes Schneider wrote:
> When CONFIG_OF_MDIO is set to be a module the code block is not
> compiled. Use the IS_ENABLED macro that checks for both built in as
> well as module.
>
> Fixes: 5dc39fd ("net: phy: DP83822: Add ability to advertise Fiber connection")
> Signed-off-by: Johannes Schneider <johannes.schneider@leica-geosystems.com>
Fixes tag needs some work:
SHA1 should be at least 12 digits long
Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
or later) just making sure it is not set (or set to "auto").
--
pw-bot: cr
prev parent reply other threads:[~2025-04-23 2:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-22 9:06 [PATCH net v2] net: dp83822: Fix OF_MDIO config check Johannes Schneider
2025-04-23 2:56 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250422195655.78124fab@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=bsp-development.geo@leica-geosystems.com \
--cc=davem@davemloft.net \
--cc=dmurphy@ti.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=johannes.schneider@leica-geosystems.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=michael@walle.cc \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).