* [PATCH net v2] net: dp83822: Fix OF_MDIO config check
@ 2025-04-22 9:06 Johannes Schneider
2025-04-23 2:56 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Johannes Schneider @ 2025-04-22 9:06 UTC (permalink / raw)
To: dmurphy
Cc: andrew, davem, f.fainelli, hkallweit1, kuba, linux-kernel, linux,
michael, netdev, bsp-development.geo, Johannes Schneider
When CONFIG_OF_MDIO is set to be a module the code block is not
compiled. Use the IS_ENABLED macro that checks for both built in as
well as module.
Fixes: 5dc39fd ("net: phy: DP83822: Add ability to advertise Fiber connection")
Signed-off-by: Johannes Schneider <johannes.schneider@leica-geosystems.com>
---
drivers/net/phy/dp83822.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/dp83822.c b/drivers/net/phy/dp83822.c
index 14f361549638..e32013eb0186 100644
--- a/drivers/net/phy/dp83822.c
+++ b/drivers/net/phy/dp83822.c
@@ -730,7 +730,7 @@ static int dp83822_phy_reset(struct phy_device *phydev)
return phydev->drv->config_init(phydev);
}
-#ifdef CONFIG_OF_MDIO
+#if IS_ENABLED(CONFIG_OF_MDIO)
static const u32 tx_amplitude_100base_tx_gain[] = {
80, 82, 83, 85, 87, 88, 90, 92,
93, 95, 97, 98, 100, 102, 103, 105,
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net v2] net: dp83822: Fix OF_MDIO config check
2025-04-22 9:06 [PATCH net v2] net: dp83822: Fix OF_MDIO config check Johannes Schneider
@ 2025-04-23 2:56 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2025-04-23 2:56 UTC (permalink / raw)
To: Johannes Schneider
Cc: dmurphy, andrew, davem, f.fainelli, hkallweit1, linux-kernel,
linux, michael, netdev, bsp-development.geo
On Tue, 22 Apr 2025 11:06:34 +0200 Johannes Schneider wrote:
> When CONFIG_OF_MDIO is set to be a module the code block is not
> compiled. Use the IS_ENABLED macro that checks for both built in as
> well as module.
>
> Fixes: 5dc39fd ("net: phy: DP83822: Add ability to advertise Fiber connection")
> Signed-off-by: Johannes Schneider <johannes.schneider@leica-geosystems.com>
Fixes tag needs some work:
SHA1 should be at least 12 digits long
Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
or later) just making sure it is not set (or set to "auto").
--
pw-bot: cr
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-04-23 2:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-22 9:06 [PATCH net v2] net: dp83822: Fix OF_MDIO config check Johannes Schneider
2025-04-23 2:56 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).