From: Jakub Kicinski <kuba@kernel.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: Saeed Mahameed <saeed@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
Saeed Mahameed <saeedm@nvidia.com>,
netdev@vger.kernel.org, Tariq Toukan <tariqt@nvidia.com>,
Gal Pressman <gal@nvidia.com>, Jiri Pirko <jiri@nvidia.com>
Subject: Re: [PATCH net-next V2 01/14] devlink: define enum for attr types of dynamic attributes
Date: Wed, 23 Apr 2025 15:07:35 -0700 [thread overview]
Message-ID: <20250423150735.566b6a52@kernel.org> (raw)
In-Reply-To: <ccwchffn6gtsy7ek4dhdqaxlbch4mptjqaqmh43a3rk7uu6dxu@jfua3hr6zxvw>
On Wed, 23 Apr 2025 13:12:56 +0200 Jiri Pirko wrote:
> >Coincidentally - you added it to the YNL spec but didn't set it for
> >the attrs that carry the values of the enum.
>
> True. Will drop it.
Hm, drop it.. in? I mean you should set:
enum: your-enum-name
on the param-type and .. fmsg-obj-value-type, I'm guessing?
next prev parent reply other threads:[~2025-04-23 22:07 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-14 19:59 [PATCH net-next V2 00/14] devlink, mlx5: Add new parameters for link management and SRIOV/eSwitch configurations Saeed Mahameed
2025-04-14 19:59 ` [PATCH net-next V2 01/14] devlink: define enum for attr types of dynamic attributes Saeed Mahameed
2025-04-17 1:08 ` Jakub Kicinski
2025-04-18 10:26 ` Jiri Pirko
2025-04-19 0:08 ` Jakub Kicinski
2025-04-22 9:14 ` Jiri Pirko
2025-04-22 14:55 ` Jakub Kicinski
2025-04-23 11:12 ` Jiri Pirko
2025-04-23 22:07 ` Jakub Kicinski [this message]
2025-04-24 9:14 ` Jiri Pirko
2025-04-14 19:59 ` [PATCH net-next V2 02/14] devlink: Add 'total_vfs' generic device param Saeed Mahameed
2025-04-14 19:59 ` [PATCH net-next V2 03/14] net/mlx5: Implement cqe_compress_type via devlink params Saeed Mahameed
2025-04-14 19:59 ` [PATCH net-next V2 04/14] net/mlx5: Implement devlink enable_sriov parameter Saeed Mahameed
2025-04-15 7:20 ` Jiri Pirko
2025-04-14 19:59 ` [PATCH net-next V2 05/14] net/mlx5: Implement devlink total_vfs parameter Saeed Mahameed
2025-04-14 19:59 ` [PATCH net-next V2 06/14] devlink: pass struct devlink_port * as arg to devlink_nl_param_fill() Saeed Mahameed
2025-04-14 19:59 ` [PATCH net-next V2 07/14] devlink: Implement port params registration Saeed Mahameed
2025-04-14 19:59 ` [PATCH net-next V2 08/14] devlink: Implement get/dump netlink commands for port params Saeed Mahameed
2025-04-14 19:59 ` [PATCH net-next V2 09/14] devlink: Implement set netlink command " Saeed Mahameed
2025-04-14 19:59 ` [PATCH net-next V2 10/14] devlink: Add 'keep_link_up' generic devlink device param Saeed Mahameed
2025-04-14 19:59 ` [PATCH net-next V2 11/14] net/mlx5: Implement devlink keep_link_up port parameter Saeed Mahameed
2025-04-14 19:59 ` [PATCH net-next V2 12/14] devlink: Throw extack messages on param value validation error Saeed Mahameed
2025-04-14 19:59 ` [PATCH net-next V2 13/14] devlink: Implement devlink param multi attribute nested data values Saeed Mahameed
2025-04-14 19:59 ` [PATCH net-next V2 14/14] net/mlx5: Implement eSwitch hairpin per prio buffers devlink params Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250423150735.566b6a52@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=jiri@nvidia.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeed@kernel.org \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).