Re: [PATCH net-next v3 2/3] devlink: add function unique identifier to devlink dev info

[Jakub Kicinski <kuba@kernel.org>]

On Wed, 23 Apr 2025 13:23:46 +0200 Jiri Pirko wrote:
> >Because you don't have a PF port for local PF.
> >
> >The information you want to convey is which of the PF ports is "local".
> >I believe we discussed this >5 years ago when I was trying to solve
> >this exact problem for the NFP.  
> 
> If you instantiate a VF devlink instance, you would also like to see
> "local" VF port? Does not make any sense to me honestly.
> 
> Why PF needs to have "local" PF port, isn't it a bit like Uroboros? The
> PF devlink instance exists, the ports are links to other entities.
> What's the reason to have a like to itself?

Neither do VF devlink instances in the first place.

> >The topology information belongs on the ports, not the main instance.  
> 
> It's not a topology information. It's an entity property. Take VF for
> example. VF also exposes FunctionUID under devlink info, same as PF.
> There is no port instance under VF devlink instance. Same for SF.
> Do you want to create dummy ports here just to have the "local" link?
> 
> I have to be missing something, the drawing as I see it fits 100%.

Very hard to understand where you're coming from since you haven't
explained why the user has to suddenly care about this new property
you're adding.