From: Jakub Kicinski <kuba@kernel.org>
To: Samiullah Khawaja <skhawaja@google.com>
Cc: "David S . Miller " <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
almasrymina@google.com, willemb@google.com, jdamato@fastly.com,
mkarsten@uwaterloo.ca, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v5 2/4] net: define an enum for the napi threaded state
Date: Fri, 25 Apr 2025 18:36:12 -0700 [thread overview]
Message-ID: <20250425183612.19068f23@kernel.org> (raw)
In-Reply-To: <20250424200222.2602990-3-skhawaja@google.com>
On Thu, 24 Apr 2025 20:02:20 +0000 Samiullah Khawaja wrote:
> - dev_set_threaded(ndev, true);
> + dev_set_threaded(ndev, NETDEV_NAPI_THREADED_ENABLE);
The drivers having to specify the type of threading is too much.
The drivers are just indicating to the core that they are too
IRQ-constrained to reasonably handle load..
Please add a wrapper, something like dev_set_threaded_hint(netdev).
All the drivers pass true now, the second argument is already
pointless. For extra points you can export just the
dev_set_threaded_hint and make dev_set_threaded() be a core-only function.
next prev parent reply other threads:[~2025-04-26 1:36 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-24 20:02 [PATCH net-next v5 0/4] Add support to do threaded napi busy poll Samiullah Khawaja
2025-04-24 20:02 ` [PATCH net-next v5 1/4] net: Create separate gro_flush helper function Samiullah Khawaja
2025-04-24 23:21 ` Joe Damato
2025-04-24 20:02 ` [PATCH net-next v5 2/4] net: define an enum for the napi threaded state Samiullah Khawaja
2025-04-24 23:40 ` Joe Damato
2025-04-26 1:36 ` Jakub Kicinski [this message]
2025-04-26 3:54 ` Samiullah Khawaja
2025-04-24 20:02 ` [PATCH net-next v5 3/4] Extend napi threaded polling to allow kthread based busy polling Samiullah Khawaja
2025-04-24 23:42 ` Joe Damato
2025-04-24 20:02 ` [PATCH net-next v5 4/4] selftests: Add napi threaded busy poll test in `busy_poller` Samiullah Khawaja
2025-04-28 13:50 ` [PATCH net-next v5 0/4] Add support to do threaded napi busy poll Martin Karsten
2025-04-28 16:52 ` Willem de Bruijn
2025-04-28 17:39 ` Joe Damato
2025-04-28 17:59 ` Willem de Bruijn
2025-04-28 18:05 ` Martin Karsten
2025-04-30 12:37 ` David Laight
2025-04-30 16:47 ` Samiullah Khawaja
2025-04-28 18:05 ` Martin Karsten
2025-04-28 18:20 ` Willem de Bruijn
2025-04-30 15:23 ` Martin Karsten
2025-04-30 16:58 ` Samiullah Khawaja
2025-04-30 19:57 ` Martin Karsten
2025-04-30 20:33 ` Samiullah Khawaja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250425183612.19068f23@kernel.org \
--to=kuba@kernel.org \
--cc=almasrymina@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jdamato@fastly.com \
--cc=mkarsten@uwaterloo.ca \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=skhawaja@google.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).