* [PATCH net] net: ethernet: mtk_eth_soc: sync mtk_clks_source_name array
@ 2025-04-25 4:29 Daniel Golle
2025-04-25 20:22 ` Simon Horman
2025-04-28 22:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Daniel Golle @ 2025-04-25 4:29 UTC (permalink / raw)
To: Felix Fietkau, Sean Wang, Lorenzo Bianconi, Andrew Lunn,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Matthias Brugger, AngeloGioacchino Del Regno, Daniel Golle,
netdev, linux-kernel, linux-arm-kernel, linux-mediatek
When removing the clock bits for clocks which aren't used by the
Ethernet driver their names should also have been removed from the
mtk_clks_source_name array.
Remove them now as enum mtk_clks_map needs to match the
mtk_clks_source_name array so the driver can make sure that all required
clocks are present and correctly name missing clocks.
Fixes: 887b1d1adb2e ("net: ethernet: mtk_eth_soc: drop clocks unused by Ethernet driver")
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
index 47807b202310..83068925c589 100644
--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
+++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
@@ -269,12 +269,8 @@ static const char * const mtk_clks_source_name[] = {
"ethwarp_wocpu2",
"ethwarp_wocpu1",
"ethwarp_wocpu0",
- "top_usxgmii0_sel",
- "top_usxgmii1_sel",
"top_sgm0_sel",
"top_sgm1_sel",
- "top_xfi_phy0_xtal_sel",
- "top_xfi_phy1_xtal_sel",
"top_eth_gmii_sel",
"top_eth_refck_50m_sel",
"top_eth_sys_200m_sel",
--
2.49.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] net: ethernet: mtk_eth_soc: sync mtk_clks_source_name array
2025-04-25 4:29 [PATCH net] net: ethernet: mtk_eth_soc: sync mtk_clks_source_name array Daniel Golle
@ 2025-04-25 20:22 ` Simon Horman
2025-04-28 22:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2025-04-25 20:22 UTC (permalink / raw)
To: Daniel Golle
Cc: Felix Fietkau, Sean Wang, Lorenzo Bianconi, Andrew Lunn,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Matthias Brugger, AngeloGioacchino Del Regno, netdev,
linux-kernel, linux-arm-kernel, linux-mediatek
On Fri, Apr 25, 2025 at 05:29:53AM +0100, Daniel Golle wrote:
> When removing the clock bits for clocks which aren't used by the
> Ethernet driver their names should also have been removed from the
> mtk_clks_source_name array.
>
> Remove them now as enum mtk_clks_map needs to match the
> mtk_clks_source_name array so the driver can make sure that all required
> clocks are present and correctly name missing clocks.
>
> Fixes: 887b1d1adb2e ("net: ethernet: mtk_eth_soc: drop clocks unused by Ethernet driver")
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] net: ethernet: mtk_eth_soc: sync mtk_clks_source_name array
2025-04-25 4:29 [PATCH net] net: ethernet: mtk_eth_soc: sync mtk_clks_source_name array Daniel Golle
2025-04-25 20:22 ` Simon Horman
@ 2025-04-28 22:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-04-28 22:20 UTC (permalink / raw)
To: Daniel Golle
Cc: nbd, sean.wang, lorenzo, andrew+netdev, davem, edumazet, kuba,
pabeni, matthias.bgg, angelogioacchino.delregno, netdev,
linux-kernel, linux-arm-kernel, linux-mediatek
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 25 Apr 2025 05:29:53 +0100 you wrote:
> When removing the clock bits for clocks which aren't used by the
> Ethernet driver their names should also have been removed from the
> mtk_clks_source_name array.
>
> Remove them now as enum mtk_clks_map needs to match the
> mtk_clks_source_name array so the driver can make sure that all required
> clocks are present and correctly name missing clocks.
>
> [...]
Here is the summary with links:
- [net] net: ethernet: mtk_eth_soc: sync mtk_clks_source_name array
https://git.kernel.org/netdev/net/c/8c47d5753a11
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-04-28 22:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-25 4:29 [PATCH net] net: ethernet: mtk_eth_soc: sync mtk_clks_source_name array Daniel Golle
2025-04-25 20:22 ` Simon Horman
2025-04-28 22:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).