From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE1A322F751 for ; Fri, 25 Apr 2025 21:48:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745617711; cv=none; b=Uo/PafRo/6O3ruBbFNbwtIg4qqz9TWgMYICB5N/h4W5qxMTCcCUJFSMvvYpXu3rNO6xVnUecEH+ENNGrJi+P1PAONrjYJioLzt0QBwZse0AKN+WpnXa8K/BqPGOASX80XNtBFSQ6qQxaELViD6mTWeq5N+taK7RHwvB1hvEga6U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745617711; c=relaxed/simple; bh=bLNACRR8zlseRPb57MfL+wQD9lYOMqUz24d4enWNqrY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lGwzDICYU3qBBYeVTdgWdC/pwr+dnlHFuUMH9hnii8tWha57MWBiIayAniGfY+vrS6Y3WUPqQbWDS2RvO0BtWNSS1/wzM8rLUYj6qVQ+e6jBOuXqJoonUWg6RB2Y7hkXw9Hr7BdAKlMXkjRj74kMMMJDk1j2ae1XKzrD7F41yQ4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=d0IytVbW; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="d0IytVbW" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7F5A2C4CEE4; Fri, 25 Apr 2025 21:48:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1745617710; bh=bLNACRR8zlseRPb57MfL+wQD9lYOMqUz24d4enWNqrY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=d0IytVbWlJX/hvx8igoEYxiVIG9xux3X657R/tm9JU9PO6ybUN9YdIsZCeoNEhFWW 6dUuiIz5B8jR8VnoiNVSmd1391erbgRZOr5kvnRrLbXONI/T0Gf/NHznF44gwikQ3M mSy5/LFvEAjV/G6uRr6+JsvBKh0RFg0W0EyoPqXzwX8ycjNYhMd3kMCBwDtSiC8Hm9 2/9K5MoFu0GfWcASLYJZSBQTF2GHTn2Fvmwau2g7u8hV3xtrsPWo/mdETlZvtZF42X Jj77fELv5Tl/0m+svM0gIVIgk6Uebq2KBQ7sYd5wVaUH+NZWU66vSffolu1/cw78y+ GKYy3/pz74d4w== From: Saeed Mahameed To: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet Cc: Saeed Mahameed , netdev@vger.kernel.org, Tariq Toukan , Gal Pressman , Leon Romanovsky , Jiri Pirko Subject: [PATCH net-next V3 13/15] devlink: Throw extack messages on param value validation error Date: Fri, 25 Apr 2025 14:48:06 -0700 Message-ID: <20250425214808.507732-14-saeed@kernel.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250425214808.507732-1-saeed@kernel.org> References: <20250425214808.507732-1-saeed@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Saeed Mahameed Centralize devlink param value data validation in one function and fill corresponding extack error messages on validation error. Reviewed-by: Jiri Pirko Signed-off-by: Saeed Mahameed --- net/devlink/param.c | 83 ++++++++++++++++++++++++++++++++++++--------- 1 file changed, 67 insertions(+), 16 deletions(-) diff --git a/net/devlink/param.c b/net/devlink/param.c index 2fc3bd2650ab..5bc7335d14b9 100644 --- a/net/devlink/param.c +++ b/net/devlink/param.c @@ -458,45 +458,96 @@ devlink_param_type_get_from_info(struct genl_info *info, return 0; } +static int +devlink_param_value_validate(struct genl_info *info, + enum devlink_param_type type) +{ + struct netlink_ext_ack *extack = info->extack; + struct nlattr *param_data; + int len = 0; + + if (type != DEVLINK_PARAM_TYPE_BOOL && + GENL_REQ_ATTR_CHECK(info, DEVLINK_ATTR_PARAM_VALUE_DATA)) + return -EINVAL; + + param_data = info->attrs[DEVLINK_ATTR_PARAM_VALUE_DATA]; + + /* bool is the only type that doesn't expect data*/ + if (type == DEVLINK_PARAM_TYPE_BOOL) { + if (param_data && nla_len(param_data)) { + NL_SET_ERR_MSG_MOD(extack, "Boolean parameter should not have data"); + return -EINVAL; + } + return 0; + } + + if (!param_data) { + NL_SET_ERR_MSG_MOD(extack, "Expected data, got none"); + return -EINVAL; + } + + len = nla_len(param_data); + switch (type) { + case DEVLINK_PARAM_TYPE_U8: + if (len == sizeof(u8)) + return 0; + NL_SET_ERR_MSG_FMT_MOD(extack, + "Expected uint8, got %d bytes", len); + break; + case DEVLINK_PARAM_TYPE_U16: + if (len == sizeof(u16)) + return 0; + NL_SET_ERR_MSG_FMT_MOD(extack, + "Expected uint16, got %d bytes", len); + break; + case DEVLINK_PARAM_TYPE_U32: + if (len == sizeof(u32)) + return 0; + NL_SET_ERR_MSG_FMT_MOD(extack, + "Expected uint32, got %d bytes", len); + break; + case DEVLINK_PARAM_TYPE_STRING: + len = strnlen(nla_data(param_data), nla_len(param_data)); + + if (len < nla_len(param_data) && + len < __DEVLINK_PARAM_MAX_STRING_VALUE) + return 0; + NL_SET_ERR_MSG_MOD(extack, "String too long"); + break; + default: + NL_SET_ERR_MSG_FMT_MOD(extack, + "Not supported value type %d", type); + break; + } + return -EINVAL; +} + static int devlink_param_value_get_from_info(const struct devlink_param *param, struct genl_info *info, union devlink_param_value *value) { struct nlattr *param_data; - int len; - param_data = info->attrs[DEVLINK_ATTR_PARAM_VALUE_DATA]; - - if (param->type != DEVLINK_PARAM_TYPE_BOOL && !param_data) + if (devlink_param_value_validate(info, param->type)) return -EINVAL; + param_data = info->attrs[DEVLINK_ATTR_PARAM_VALUE_DATA]; + switch (param->type) { case DEVLINK_PARAM_TYPE_U8: - if (nla_len(param_data) != sizeof(u8)) - return -EINVAL; value->vu8 = nla_get_u8(param_data); break; case DEVLINK_PARAM_TYPE_U16: - if (nla_len(param_data) != sizeof(u16)) - return -EINVAL; value->vu16 = nla_get_u16(param_data); break; case DEVLINK_PARAM_TYPE_U32: - if (nla_len(param_data) != sizeof(u32)) - return -EINVAL; value->vu32 = nla_get_u32(param_data); break; case DEVLINK_PARAM_TYPE_STRING: - len = strnlen(nla_data(param_data), nla_len(param_data)); - if (len == nla_len(param_data) || - len >= __DEVLINK_PARAM_MAX_STRING_VALUE) - return -EINVAL; strcpy(value->vstr, nla_data(param_data)); break; case DEVLINK_PARAM_TYPE_BOOL: - if (param_data && nla_len(param_data)) - return -EINVAL; value->vbool = nla_get_flag(param_data); break; } -- 2.49.0