From: Thorsten Blum <thorsten.blum@linux.dev>
To: Jon Maloy <jmaloy@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>
Cc: Thorsten Blum <thorsten.blum@linux.dev>,
netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: [PATCH net-next] tipc: Replace msecs_to_jiffies() with secs_to_jiffies()
Date: Sat, 26 Apr 2025 12:04:44 +0200 [thread overview]
Message-ID: <20250426100445.57221-1-thorsten.blum@linux.dev> (raw)
Use secs_to_jiffies() instead of msecs_to_jiffies() and avoid scaling
'delay' to milliseconds in tipc_crypto_rekeying_sched(). Compared to
msecs_to_jiffies(), secs_to_jiffies() expands to simpler code and
reduces the size of 'tipc.ko'.
Remove unnecessary parentheses around the local variable 'now'.
No functional changes intended.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
net/tipc/crypto.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/net/tipc/crypto.c b/net/tipc/crypto.c
index c524421ec652..45edb29b6bd7 100644
--- a/net/tipc/crypto.c
+++ b/net/tipc/crypto.c
@@ -41,10 +41,10 @@
#include "msg.h"
#include "bcast.h"
-#define TIPC_TX_GRACE_PERIOD msecs_to_jiffies(5000) /* 5s */
-#define TIPC_TX_LASTING_TIME msecs_to_jiffies(10000) /* 10s */
-#define TIPC_RX_ACTIVE_LIM msecs_to_jiffies(3000) /* 3s */
-#define TIPC_RX_PASSIVE_LIM msecs_to_jiffies(15000) /* 15s */
+#define TIPC_TX_GRACE_PERIOD secs_to_jiffies(5)
+#define TIPC_TX_LASTING_TIME secs_to_jiffies(10)
+#define TIPC_RX_ACTIVE_LIM secs_to_jiffies(3)
+#define TIPC_RX_PASSIVE_LIM secs_to_jiffies(15)
#define TIPC_MAX_TFMS_DEF 10
#define TIPC_MAX_TFMS_LIM 1000
@@ -2348,7 +2348,7 @@ static void tipc_crypto_work_rx(struct work_struct *work)
struct delayed_work *dwork = to_delayed_work(work);
struct tipc_crypto *rx = container_of(dwork, struct tipc_crypto, work);
struct tipc_crypto *tx = tipc_net(rx->net)->crypto_tx;
- unsigned long delay = msecs_to_jiffies(5000);
+ unsigned long delay = secs_to_jiffies(5);
bool resched = false;
u8 key;
int rc;
@@ -2418,8 +2418,8 @@ void tipc_crypto_rekeying_sched(struct tipc_crypto *tx, bool changed,
}
if (tx->rekeying_intv || now) {
- delay = (now) ? 0 : tx->rekeying_intv * 60 * 1000;
- queue_delayed_work(tx->wq, &tx->work, msecs_to_jiffies(delay));
+ delay = now ? 0 : tx->rekeying_intv * 60;
+ queue_delayed_work(tx->wq, &tx->work, secs_to_jiffies(delay));
}
}
--
2.49.0
next reply other threads:[~2025-04-26 10:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-26 10:04 Thorsten Blum [this message]
2025-04-28 2:31 ` [PATCH net-next] tipc: Replace msecs_to_jiffies() with secs_to_jiffies() Tung Quang Nguyen
2025-04-28 13:23 ` Thorsten Blum
2025-04-28 13:42 ` Tung Quang Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250426100445.57221-1-thorsten.blum@linux.dev \
--to=thorsten.blum@linux.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jmaloy@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tipc-discussion@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).