From: Jakub Kicinski <kuba@kernel.org>
To: Kory Maincent <kory.maincent@bootlin.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
thomas.petazzoni@bootlin.com, Andrew Lunn <andrew@lunn.ch>,
Donald Hunter <donald.hunter@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>
Subject: Re: [PATCH net-next] netlink: specs: ethtool: Remove UAPI duplication of phy-upstream enum
Date: Mon, 28 Apr 2025 15:51:19 -0700 [thread overview]
Message-ID: <20250428155119.386e62c8@kernel.org> (raw)
In-Reply-To: <20250425171419.947352-1-kory.maincent@bootlin.com>
On Fri, 25 Apr 2025 19:14:18 +0200 Kory Maincent wrote:
> The phy-upstream enum is already defined in the ethtool.h UAPI header
> and used by the ethtool userspace tool. However, the ethtool spec does
> not reference it, causing YNL to auto-generate a duplicate and redundant
> enum.
>
> Fix this by updating the spec to reference the existing UAPI enum
> in ethtool.h.
>
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> ---
> Not sure if it should be sent as a fix as there is no real issue here.
Indeed, but better deliver it to users ASAP otherwise some app
may start using this unnecessary enum.
next prev parent reply other threads:[~2025-04-28 22:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-25 17:14 [PATCH net-next] netlink: specs: ethtool: Remove UAPI duplication of phy-upstream enum Kory Maincent
2025-04-28 22:51 ` Jakub Kicinski [this message]
2025-04-28 23:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250428155119.386e62c8@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kory.maincent@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).