From: Jakub Kicinski <kuba@kernel.org>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
andrew+netdev@lunn.ch, netdev@vger.kernel.org,
Milena Olech <milena.olech@intel.com>,
przemyslaw.kitszel@intel.com, jacob.e.keller@intel.com,
richardcochran@gmail.com, Josh Hay <joshua.a.hay@intel.com>,
Samuel Salin <Samuel.salin@intel.com>
Subject: Re: [PATCH net-next v2 10/11] idpf: add Tx timestamp flows
Date: Mon, 28 Apr 2025 17:37:18 -0700 [thread overview]
Message-ID: <20250428173718.2f70e465@kernel.org> (raw)
In-Reply-To: <20250425215227.3170837-11-anthony.l.nguyen@intel.com>
On Fri, 25 Apr 2025 14:52:24 -0700 Tony Nguyen wrote:
> @@ -479,6 +480,9 @@ static const struct idpf_stats idpf_gstrings_port_stats[] = {
> IDPF_PORT_STAT("tx-unicast_pkts", port_stats.vport_stats.tx_unicast),
> IDPF_PORT_STAT("tx-multicast_pkts", port_stats.vport_stats.tx_multicast),
> IDPF_PORT_STAT("tx-broadcast_pkts", port_stats.vport_stats.tx_broadcast),
> + IDPF_PORT_STAT("tx-hwtstamp_skipped", port_stats.tx_hwtstamp_skipped),
> + IDPF_PORT_STAT("tx-hwtstamp_flushed", tstamp_stats.tx_hwtstamp_flushed),
> + IDPF_PORT_STAT("tx-hwtstamp_discarded", tstamp_stats.tx_hwtstamp_discarded),
> };
I don't see the implementation of the standard stats via get_ts_stats
You must implement standard stats before exposing custom breakdown.
next prev parent reply other threads:[~2025-04-29 0:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-25 21:52 [PATCH net-next v2 00/11][pull request] idpf: add initial PTP support Tony Nguyen
2025-04-25 21:52 ` [PATCH net-next v2 01/11] idpf: change the method for mailbox workqueue allocation Tony Nguyen
2025-04-25 21:52 ` [PATCH net-next v2 02/11] idpf: add initial PTP support Tony Nguyen
2025-04-25 21:52 ` [PATCH net-next v2 03/11] virtchnl: add PTP virtchnl definitions Tony Nguyen
2025-04-25 21:52 ` [PATCH net-next v2 04/11] idpf: move virtchnl structures to the header file Tony Nguyen
2025-04-25 21:52 ` [PATCH net-next v2 05/11] idpf: negotiate PTP capabilities and get PTP clock Tony Nguyen
2025-04-25 21:52 ` [PATCH net-next v2 06/11] idpf: add mailbox access to read PTP clock time Tony Nguyen
2025-04-25 21:52 ` [PATCH net-next v2 07/11] idpf: add cross timestamping Tony Nguyen
2025-04-25 21:52 ` [PATCH net-next v2 08/11] idpf: add PTP clock configuration Tony Nguyen
2025-04-25 21:52 ` [PATCH net-next v2 09/11] idpf: add Tx timestamp capabilities negotiation Tony Nguyen
2025-04-25 21:52 ` [PATCH net-next v2 10/11] idpf: add Tx timestamp flows Tony Nguyen
2025-04-29 0:35 ` Jakub Kicinski
2025-05-05 17:08 ` Olech, Milena
2025-05-05 19:00 ` Jakub Kicinski
2025-04-29 0:37 ` Jakub Kicinski [this message]
2025-04-29 20:06 ` Jacob Keller
2025-04-25 21:52 ` [PATCH net-next v2 11/11] idpf: add support for Rx timestamping Tony Nguyen
2025-04-29 0:39 ` [PATCH net-next v2 00/11][pull request] idpf: add initial PTP support Jakub Kicinski
2025-04-29 21:41 ` Tony Nguyen
2025-04-29 21:52 ` Jakub Kicinski
2025-05-05 17:20 ` Olech, Milena
2025-05-05 19:02 ` Jakub Kicinski
2025-05-06 14:50 ` Olech, Milena
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250428173718.2f70e465@kernel.org \
--to=kuba@kernel.org \
--cc=Samuel.salin@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jacob.e.keller@intel.com \
--cc=joshua.a.hay@intel.com \
--cc=milena.olech@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).