From: Simon Horman <horms@kernel.org>
To: Da Xue <da@libre.computer>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
Christian Hewitt <christianshewitt@gmail.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v3] net: mdio: mux-meson-gxl: set reversed bit when using internal phy
Date: Mon, 28 Apr 2025 19:12:42 +0100 [thread overview]
Message-ID: <20250428181242.GG3339421@horms.kernel.org> (raw)
In-Reply-To: <20250425192009.1439508-1-da@libre.computer>
On Fri, Apr 25, 2025 at 03:20:09PM -0400, Da Xue wrote:
> This bit is necessary to receive packets from the internal PHY.
> Without this bit set, no activity occurs on the interface.
>
> Normally u-boot sets this bit, but if u-boot is compiled without
> net support, the interface will be up but without any activity.
>
> The vendor SDK sets this bit along with the PHY_ID bits.
I'd like to clarify that:
Without this patch the writel the patch is modifying will clear the PHY_ID bit.
But despite that the system works if at some point (uboot) set the PHY_ID bit?
>
> Fixes: 9a24e1ff4326 ("net: mdio: add amlogic gxl mdio mux support");
I don't think you need to resend because of this,
but the correct syntax is as follows. (No trailing ';'.)
Fixes: 9a24e1ff4326 ("net: mdio: add amlogic gxl mdio mux support")
> Signed-off-by: Da Xue <da@libre.computer>
> ---
> Changes since v2:
> * Rename REG2_RESERVED_28 to REG2_REVERSED
>
> Link to v2:
> https://patchwork.kernel.org/project/linux-amlogic/patch/20250331074420.3443748-1-christianshewitt@gmail.com/
...
next prev parent reply other threads:[~2025-04-28 18:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-25 19:20 [PATCH v3] net: mdio: mux-meson-gxl: set reversed bit when using internal phy Da Xue
2025-04-28 18:12 ` Simon Horman [this message]
2025-04-29 0:44 ` Da Xue
2025-04-29 19:02 ` Jakub Kicinski
2025-04-29 19:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250428181242.GG3339421@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew@lunn.ch \
--cc=christianshewitt@gmail.com \
--cc=da@libre.computer \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=kuba@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).