From: Simon Horman <horms@kernel.org>
To: Shannon Nelson <shannon.nelson@amd.com>
Cc: andrew+netdev@lunn.ch, brett.creeley@amd.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next 3/3] pds_core: init viftype default in declaration
Date: Mon, 28 Apr 2025 20:26:40 +0100 [thread overview]
Message-ID: <20250428192640.GJ3339421@horms.kernel.org> (raw)
In-Reply-To: <20250425204618.72783-4-shannon.nelson@amd.com>
On Fri, Apr 25, 2025 at 01:46:18PM -0700, Shannon Nelson wrote:
> Initialize the .enabled field of the FWCTL viftype default in
> the declaration rather than as a bit of code as it is always
> to be enabled and needs no logic around it.
>
> Signed-off-by: Shannon Nelson <shannon.nelson@amd.com>
Thanks, this looks like a nice clean-up to me.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-04-28 19:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-25 20:46 [PATCH net-next 0/3] pds_core: small code updates Shannon Nelson
2025-04-25 20:46 ` [PATCH net-next 1/3] pds_core: remove extra name description Shannon Nelson
2025-04-25 20:46 ` [PATCH net-next 2/3] pds_core: smaller adminq poll starting interval Shannon Nelson
2025-04-28 19:27 ` Simon Horman
2025-04-25 20:46 ` [PATCH net-next 3/3] pds_core: init viftype default in declaration Shannon Nelson
2025-04-28 19:26 ` Simon Horman [this message]
2025-04-30 12:10 ` [PATCH net-next 0/3] pds_core: small code updates patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250428192640.GJ3339421@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=brett.creeley@amd.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shannon.nelson@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).