[PATCH net-next 0/3] pds_core: small code updates

[PATCH net-next 0/3] pds_core: small code updates

[Shannon Nelson]

These are a few little code touch ups for a kdoc complaint,
quicker error detection, and a cleaner initialization.

Shannon Nelson (3):
  pds_core: remove extra name description
  pds_core: smaller adminq poll starting interval
  pds_core: init viftype default in declaration

 drivers/net/ethernet/amd/pds_core/adminq.c | 4 ++--
 drivers/net/ethernet/amd/pds_core/core.c   | 4 +---
 include/linux/pds/pds_adminq.h             | 3 +--
 3 files changed, 4 insertions(+), 7 deletions(-)

-- 
2.17.1

[PATCH net-next 1/3] pds_core: remove extra name description

[Shannon Nelson]

Fix the kernel-doc complaint
include/linux/pds/pds_adminq.h:481: warning: Excess struct member 'name' description in 'pds_core_lif_getattr_comp'

Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: Shannon Nelson <shannon.nelson@amd.com>
---
 include/linux/pds/pds_adminq.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/include/linux/pds/pds_adminq.h b/include/linux/pds/pds_adminq.h
index ddd111f04ca0..339156113fa5 100644
--- a/include/linux/pds/pds_adminq.h
+++ b/include/linux/pds/pds_adminq.h
@@ -463,7 +463,6 @@ struct pds_core_lif_getattr_cmd {
  * @rsvd:       Word boundary padding
  * @comp_index: Index in the descriptor ring for which this is the completion
  * @state:	LIF state (enum pds_core_lif_state)
- * @name:	LIF name string, 0 terminated
  * @features:	Features (enum pds_core_hw_features)
  * @rsvd2:      Word boundary padding
  * @color:	Color bit
-- 
2.17.1

[PATCH net-next 2/3] pds_core: smaller adminq poll starting interval

[Shannon Nelson]

Shorten the adminq poll starting interval in order to notice
any transaction errors more quickly.

Signed-off-by: Shannon Nelson <shannon.nelson@amd.com>
---
 drivers/net/ethernet/amd/pds_core/adminq.c | 4 ++--
 include/linux/pds/pds_adminq.h             | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/amd/pds_core/adminq.c b/drivers/net/ethernet/amd/pds_core/adminq.c
index 506f682d15c1..097bb092bdb8 100644
--- a/drivers/net/ethernet/amd/pds_core/adminq.c
+++ b/drivers/net/ethernet/amd/pds_core/adminq.c
@@ -225,7 +225,7 @@ int pdsc_adminq_post(struct pdsc *pdsc,
 		     union pds_core_adminq_comp *comp,
 		     bool fast_poll)
 {
-	unsigned long poll_interval = 1;
+	unsigned long poll_interval = 200;
 	unsigned long poll_jiffies;
 	unsigned long time_limit;
 	unsigned long time_start;
@@ -252,7 +252,7 @@ int pdsc_adminq_post(struct pdsc *pdsc,
 	time_limit = time_start + HZ * pdsc->devcmd_timeout;
 	do {
 		/* Timeslice the actual wait to catch IO errors etc early */
-		poll_jiffies = msecs_to_jiffies(poll_interval);
+		poll_jiffies = usecs_to_jiffies(poll_interval);
 		remaining = wait_for_completion_timeout(wc, poll_jiffies);
 		if (remaining)
 			break;
diff --git a/include/linux/pds/pds_adminq.h b/include/linux/pds/pds_adminq.h
index 339156113fa5..40ff0ec2b879 100644
--- a/include/linux/pds/pds_adminq.h
+++ b/include/linux/pds/pds_adminq.h
@@ -4,7 +4,7 @@
 #ifndef _PDS_CORE_ADMINQ_H_
 #define _PDS_CORE_ADMINQ_H_
 
-#define PDSC_ADMINQ_MAX_POLL_INTERVAL	256
+#define PDSC_ADMINQ_MAX_POLL_INTERVAL	256000	/* usecs */
 
 enum pds_core_adminq_flags {
 	PDS_AQ_FLAG_FASTPOLL	= BIT(1),	/* completion poll at 1ms */
-- 
2.17.1

[PATCH net-next 3/3] pds_core: init viftype default in declaration

[Shannon Nelson]

Initialize the .enabled field of the FWCTL viftype default in
the declaration rather than as a bit of code as it is always
to be enabled and needs no logic around it.

Signed-off-by: Shannon Nelson <shannon.nelson@amd.com>
---
 drivers/net/ethernet/amd/pds_core/core.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/amd/pds_core/core.c b/drivers/net/ethernet/amd/pds_core/core.c
index 9512aa4083f0..223547e4077f 100644
--- a/drivers/net/ethernet/amd/pds_core/core.c
+++ b/drivers/net/ethernet/amd/pds_core/core.c
@@ -402,6 +402,7 @@ static int pdsc_core_init(struct pdsc *pdsc)
 
 static struct pdsc_viftype pdsc_viftype_defaults[] = {
 	[PDS_DEV_TYPE_FWCTL] = { .name = PDS_DEV_TYPE_FWCTL_STR,
+				 .enabled = true,
 				 .vif_id = PDS_DEV_TYPE_FWCTL,
 				 .dl_id = -1 },
 	[PDS_DEV_TYPE_VDPA] = { .name = PDS_DEV_TYPE_VDPA_STR,
@@ -431,9 +432,6 @@ static int pdsc_viftypes_init(struct pdsc *pdsc)
 		/* See what the Core device has for support */
 		vt_support = !!le16_to_cpu(pdsc->dev_ident.vif_types[vt]);
 
-		if (vt == PDS_DEV_TYPE_FWCTL)
-			pdsc->viftype_status[vt].enabled = true;
-
 		dev_dbg(pdsc->dev, "VIF %s is %ssupported\n",
 			pdsc->viftype_status[vt].name,
 			vt_support ? "" : "not ");
-- 
2.17.1

Re: [PATCH net-next 3/3] pds_core: init viftype default in declaration

[Simon Horman]

On Fri, Apr 25, 2025 at 01:46:18PM -0700, Shannon Nelson wrote:
> Initialize the .enabled field of the FWCTL viftype default in
> the declaration rather than as a bit of code as it is always
> to be enabled and needs no logic around it.
> 
> Signed-off-by: Shannon Nelson <shannon.nelson@amd.com>

Thanks, this looks like a nice clean-up to me.

Reviewed-by: Simon Horman <horms@kernel.org>

Re: [PATCH net-next 2/3] pds_core: smaller adminq poll starting interval

[Simon Horman]

On Fri, Apr 25, 2025 at 01:46:17PM -0700, Shannon Nelson wrote:
> Shorten the adminq poll starting interval in order to notice
> any transaction errors more quickly.

It might be nice to add a bit more colour to what sort of scenarios
this helps. But that isn't a hard requirement from my side.

> 
> Signed-off-by: Shannon Nelson <shannon.nelson@amd.com>

Reviewed-by: Simon Horman <horms@kernel.org>

Re: [PATCH net-next 0/3] pds_core: small code updates

[patchwork-bot+netdevbpf]

Hello:

This series was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:

On Fri, 25 Apr 2025 13:46:15 -0700 you wrote:
> These are a few little code touch ups for a kdoc complaint,
> quicker error detection, and a cleaner initialization.
> 
> Shannon Nelson (3):
>   pds_core: remove extra name description
>   pds_core: smaller adminq poll starting interval
>   pds_core: init viftype default in declaration
> 
> [...]

Here is the summary with links:
  - [net-next,1/3] pds_core: remove extra name description
    https://git.kernel.org/netdev/net-next/c/144530c15ec7
  - [net-next,2/3] pds_core: smaller adminq poll starting interval
    https://git.kernel.org/netdev/net-next/c/7c4f4c4fa9b6
  - [net-next,3/3] pds_core: init viftype default in declaration
    https://git.kernel.org/netdev/net-next/c/6828208a45c1

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html