From: Simon Horman <horms@kernel.org>
To: Kees Cook <kees@kernel.org>
Cc: Louis Peens <louis.peens@corigine.com>,
Jakub Kicinski <kuba@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Yinjun Zhang <yinjun.zhang@corigine.com>,
Diana Wang <na.wang@corigine.com>,
oss-drivers@corigine.com, netdev@vger.kernel.org,
Jacob Keller <jacob.e.keller@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Jinjie Ruan <ruanjinjie@huawei.com>,
Easwar Hariharan <eahariha@linux.microsoft.com>,
Mohammad Heib <mheib@redhat.com>,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] nfp: xsk: Adjust allocation type for nn->dp.xsk_pools
Date: Mon, 28 Apr 2025 21:04:57 +0100 [thread overview]
Message-ID: <20250428200457.GN3339421@horms.kernel.org> (raw)
In-Reply-To: <20250426060841.work.016-kees@kernel.org>
On Fri, Apr 25, 2025 at 11:08:42PM -0700, Kees Cook wrote:
> In preparation for making the kmalloc family of allocators type aware,
> we need to make sure that the returned type from the allocation matches
> the type of the variable being assigned. (Before, the allocator would
> always return "void *", which can be implicitly cast to any pointer type.)
>
> The assigned type "struct xsk_buff_pool **", but the returned type will be
> "struct xsk_buff_pool ***". These are the same allocation size (pointer
> size), but the types don't match. Adjust the allocation type to match
> the assignment.
>
> Signed-off-by: Kees Cook <kees@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-04-28 20:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-26 6:08 [PATCH] nfp: xsk: Adjust allocation type for nn->dp.xsk_pools Kees Cook
2025-04-28 20:04 ` Simon Horman [this message]
2025-04-29 18:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250428200457.GN3339421@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=eahariha@linux.microsoft.com \
--cc=edumazet@google.com \
--cc=jacob.e.keller@intel.com \
--cc=kees@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=louis.peens@corigine.com \
--cc=mheib@redhat.com \
--cc=na.wang@corigine.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@corigine.com \
--cc=pabeni@redhat.com \
--cc=ruanjinjie@huawei.com \
--cc=tglx@linutronix.de \
--cc=yinjun.zhang@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).