From: Jakub Kicinski <kuba@kernel.org>
To: Shankari Anand <shankari.ak0208@gmail.com>
Cc: netdev@vger.kernel.org, allison.henderson@oracle.com,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
horms@kernel.org, shuah@kernel.org
Subject: Re: [PATCH v2] net: rds: Replace strncpy with strscpy in connection setup
Date: Tue, 29 Apr 2025 11:09:19 -0700 [thread overview]
Message-ID: <20250429110919.37ceacce@kernel.org> (raw)
In-Reply-To: <20250426192113.47012-1-shankari.ak0208@gmail.com>
On Sun, 27 Apr 2025 00:51:13 +0530 Shankari Anand wrote:
> From: Shankari02 <shankari.ak0208@gmail.com>
Not your full name, the last From: in the email is what matters.
Maybe try to correct the author of the commit in your git tree.
> This patch replaces strncpy() with strscpy(), which is the preferred, safer
> alternative for bounded string copying in the Linux kernel. strscpy() guarantees
> null-termination as long as the destination buffer is non-zero in size and provides
> a return value to detect truncation.
Please wrap the commit message at 72 chars.
> Padding of the 'transport' field is not necessary because it is treated purely
> as a null-terminated string and is not used for binary comparisons or direct
> memory operations that would rely on padding. Therefore, switching to strscpy()
> is safe and appropriate here.
It's treated as purely null-terminated string? Where exactly
in the code do you see that? Because all I see is a memcpy..
prev parent reply other threads:[~2025-04-29 18:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-23 15:37 [PATCH] net: rds: Replace strncpy with strscpy in connection setup Shankari02
2025-04-25 1:36 ` Jakub Kicinski
2025-04-26 19:21 ` [PATCH v2] " Shankari Anand
2025-04-26 19:26 ` Shankari
2025-04-30 18:16 ` Simon Horman
2025-05-21 5:52 ` [PATCH v3] " Shankari Anand
2025-05-21 5:54 ` Shankari Anand
2025-05-21 12:58 ` [PATCH v4] " Shankari Anand
2025-05-21 17:21 ` Allison Henderson
2025-05-21 6:05 ` [PATCH v3] " Shankari Anand
2025-04-28 23:25 ` [PATCH v2] " Allison Henderson
2025-04-29 18:09 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250429110919.37ceacce@kernel.org \
--to=kuba@kernel.org \
--cc=allison.henderson@oracle.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shankari.ak0208@gmail.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).