From: Simon Horman <horms@kernel.org>
To: mattiasbarthel@gmail.com
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, wei.fang@nxp.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Mattias Barthel <mattias.barthel@atlascopco.com>
Subject: Re: [PATCH net] fec: Workaround for ERR007885 on fec_enet_txq_submit_skb()
Date: Tue, 29 Apr 2025 15:58:06 +0100 [thread overview]
Message-ID: <20250429145806.GO3339421@horms.kernel.org> (raw)
In-Reply-To: <20250428111018.3048176-1-mattiasbarthel@gmail.com>
On Mon, Apr 28, 2025 at 01:10:18PM +0200, mattiasbarthel@gmail.com wrote:
> From: Mattias Barthel <mattias.barthel@atlascopco.com>
>
> Activate workaround also in fec_enet_txq_submit_skb() for when TSO is not enbabled.
>
> Errata: ERR007885
> Symptoms: NETDEV WATCHDOG: eth0 (fec): transmit queue 0 timed out
>
> reference commit 37d6017b84f7 ("net: fec: Workaround for imx6sx enet tx hang when enable three queues"),
Hi Mattias,
The commit cited above includes an explanation of the problem
and the work around. I think this commit message could
benefit from a similar level of detail.
>
> Signed-off-by: Mattias Barthel <mattias.barthel@atlascopco.com>
...
next prev parent reply other threads:[~2025-04-29 14:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-28 11:10 [PATCH net] fec: Workaround for ERR007885 on fec_enet_txq_submit_skb() mattiasbarthel
2025-04-28 11:24 ` Wei Fang
2025-04-28 11:26 ` Wei Fang
2025-04-29 14:58 ` Simon Horman [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-04-28 11:49 mattiasbarthel
2025-04-28 13:07 ` Andrew Lunn
2025-04-28 12:43 mattiasbarthel
2025-04-28 13:09 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250429145806.GO3339421@horms.kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mattias.barthel@atlascopco.com \
--cc=mattiasbarthel@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wei.fang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).