netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
	andrew+netdev@lunn.ch, horms@kernel.org, donald.hunter@gmail.com,
	jacob.e.keller@intel.com, sdf@fomichev.me, jdamato@fastly.com,
	nicolas.dichtel@6wind.com, Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH net-next v3 03/12] tools: ynl-gen: fill in missing empty attr lists
Date: Tue, 29 Apr 2025 08:46:55 -0700	[thread overview]
Message-ID: <20250429154704.2613851-4-kuba@kernel.org> (raw)
In-Reply-To: <20250429154704.2613851-1-kuba@kernel.org>

The C codegen refers to op attribute lists all over the place,
without checking if they are present, even tho attribute list
is technically an optional property. Add them automatically
at init if missing so that we don't have to make specs longer.

Reviewed-by: Donald Hunter <donald.hunter@gmail.com>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
v2:
 - use Jake's suggestion
v1: https://lore.kernel.org/20250424021207.1167791-4-kuba@kernel.org
---
 tools/net/ynl/pyynl/ynl_gen_c.py | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/tools/net/ynl/pyynl/ynl_gen_c.py b/tools/net/ynl/pyynl/ynl_gen_c.py
index 90f7fe6b623b..898c41a7a81f 100755
--- a/tools/net/ynl/pyynl/ynl_gen_c.py
+++ b/tools/net/ynl/pyynl/ynl_gen_c.py
@@ -938,6 +938,14 @@ from lib import SpecFamily, SpecAttrSet, SpecAttr, SpecOperation, SpecEnumSet, S
 
 class Operation(SpecOperation):
     def __init__(self, family, yaml, req_value, rsp_value):
+        # Fill in missing operation properties (for fixed hdr-only msgs)
+        for mode in ['do', 'dump', 'event']:
+            for direction in ['request', 'reply']:
+                try:
+                    yaml[mode][direction].setdefault('attributes', [])
+                except KeyError:
+                    pass
+
         super().__init__(family, yaml, req_value, rsp_value)
 
         self.render_name = c_lower(family.ident_name + '_' + self.name)
-- 
2.49.0


  parent reply	other threads:[~2025-04-29 15:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-29 15:46 [PATCH net-next v3 00/12] tools: ynl-gen: additional C types and classic netlink handling Jakub Kicinski
2025-04-29 15:46 ` [PATCH net-next v3 01/12] tools: ynl-gen: fix comment about nested struct dict Jakub Kicinski
2025-04-29 15:46 ` [PATCH net-next v3 02/12] tools: ynl-gen: factor out free_needs_iter for a struct Jakub Kicinski
2025-04-29 15:46 ` Jakub Kicinski [this message]
2025-04-29 15:46 ` [PATCH net-next v3 04/12] tools: ynl: let classic netlink requests specify extra nlflags Jakub Kicinski
2025-04-29 15:46 ` [PATCH net-next v3 05/12] tools: ynl-gen: support using dump types for ntf Jakub Kicinski
2025-04-29 15:46 ` [PATCH net-next v3 06/12] tools: ynl-gen: support CRUD-like notifications for classic Netlink Jakub Kicinski
2025-04-29 15:46 ` [PATCH net-next v3 07/12] tools: ynl-gen: multi-attr: type gen for string Jakub Kicinski
2025-04-29 15:47 ` [PATCH net-next v3 08/12] tools: ynl-gen: mutli-attr: support binary types with struct Jakub Kicinski
2025-04-29 15:47 ` [PATCH net-next v3 09/12] tools: ynl-gen: array-nest: support put for scalar Jakub Kicinski
2025-04-29 15:47 ` [PATCH net-next v3 10/12] tools: ynl-gen: array-nest: support binary array with exact-len Jakub Kicinski
2025-04-29 15:47 ` [PATCH net-next v3 11/12] tools: ynl-gen: don't init enum checks for classic netlink Jakub Kicinski
2025-04-29 15:47 ` [PATCH net-next v3 12/12] tools: ynl: allow fixed-header to be specified per op Jakub Kicinski
2025-05-02 10:50 ` [PATCH net-next v3 00/12] tools: ynl-gen: additional C types and classic netlink handling patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250429154704.2613851-4-kuba@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=donald.hunter@gmail.com \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=jacob.e.keller@intel.com \
    --cc=jdamato@fastly.com \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.dichtel@6wind.com \
    --cc=pabeni@redhat.com \
    --cc=sdf@fomichev.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).