From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
andrew+netdev@lunn.ch, horms@kernel.org, donald.hunter@gmail.com,
jacob.e.keller@intel.com, sdf@fomichev.me, jdamato@fastly.com,
nicolas.dichtel@6wind.com, Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH net-next v3 06/12] tools: ynl-gen: support CRUD-like notifications for classic Netlink
Date: Tue, 29 Apr 2025 08:46:58 -0700 [thread overview]
Message-ID: <20250429154704.2613851-7-kuba@kernel.org> (raw)
In-Reply-To: <20250429154704.2613851-1-kuba@kernel.org>
Allow CRUD-style notification where the notification is more
like the response to the request, which can optionally be
looped back onto the requesting socket. Since the notification
and request are different ops in the spec, for example:
-
name: delrule
doc: Remove an existing FIB rule
attribute-set: fib-rule-attrs
do:
request:
value: 33
attributes: *fib-rule-all
-
name: delrule-ntf
doc: Notify a rule deletion
value: 33
notify: getrule
We need to find the request by ID. Ideally we'd detect this model
from the spec properties, rather than assume that its what all
classic netlink families do. But maybe that'd cause this model
to spread and its easy to get wrong. For now assume CRUD == classic.
Reviewed-by: Donald Hunter <donald.hunter@gmail.com>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
tools/net/ynl/pyynl/ynl_gen_c.py | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tools/net/ynl/pyynl/ynl_gen_c.py b/tools/net/ynl/pyynl/ynl_gen_c.py
index 0febbb3912e3..31e904f1a2f0 100755
--- a/tools/net/ynl/pyynl/ynl_gen_c.py
+++ b/tools/net/ynl/pyynl/ynl_gen_c.py
@@ -2787,7 +2787,11 @@ _C_KW = {
def _render_user_ntf_entry(ri, op):
- ri.cw.block_start(line=f"[{op.enum_name}] = ")
+ if not ri.family.is_classic():
+ ri.cw.block_start(line=f"[{op.enum_name}] = ")
+ else:
+ crud_op = ri.family.req_by_value[op.rsp_value]
+ ri.cw.block_start(line=f"[{crud_op.enum_name}] = ")
ri.cw.p(f".alloc_sz\t= sizeof({type_name(ri, 'event')}),")
ri.cw.p(f".cb\t\t= {op_prefix(ri, 'reply', deref=True)}_parse,")
ri.cw.p(f".policy\t\t= &{ri.struct['reply'].render_name}_nest,")
--
2.49.0
next prev parent reply other threads:[~2025-04-29 15:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-29 15:46 [PATCH net-next v3 00/12] tools: ynl-gen: additional C types and classic netlink handling Jakub Kicinski
2025-04-29 15:46 ` [PATCH net-next v3 01/12] tools: ynl-gen: fix comment about nested struct dict Jakub Kicinski
2025-04-29 15:46 ` [PATCH net-next v3 02/12] tools: ynl-gen: factor out free_needs_iter for a struct Jakub Kicinski
2025-04-29 15:46 ` [PATCH net-next v3 03/12] tools: ynl-gen: fill in missing empty attr lists Jakub Kicinski
2025-04-29 15:46 ` [PATCH net-next v3 04/12] tools: ynl: let classic netlink requests specify extra nlflags Jakub Kicinski
2025-04-29 15:46 ` [PATCH net-next v3 05/12] tools: ynl-gen: support using dump types for ntf Jakub Kicinski
2025-04-29 15:46 ` Jakub Kicinski [this message]
2025-04-29 15:46 ` [PATCH net-next v3 07/12] tools: ynl-gen: multi-attr: type gen for string Jakub Kicinski
2025-04-29 15:47 ` [PATCH net-next v3 08/12] tools: ynl-gen: mutli-attr: support binary types with struct Jakub Kicinski
2025-04-29 15:47 ` [PATCH net-next v3 09/12] tools: ynl-gen: array-nest: support put for scalar Jakub Kicinski
2025-04-29 15:47 ` [PATCH net-next v3 10/12] tools: ynl-gen: array-nest: support binary array with exact-len Jakub Kicinski
2025-04-29 15:47 ` [PATCH net-next v3 11/12] tools: ynl-gen: don't init enum checks for classic netlink Jakub Kicinski
2025-04-29 15:47 ` [PATCH net-next v3 12/12] tools: ynl: allow fixed-header to be specified per op Jakub Kicinski
2025-05-02 10:50 ` [PATCH net-next v3 00/12] tools: ynl-gen: additional C types and classic netlink handling patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250429154704.2613851-7-kuba@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=jdamato@fastly.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).