netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next v0] net: phy: aquantia: fix commenting format
@ 2025-04-28 21:49 Aryan Srivastava
  2025-04-29 20:03 ` Simon Horman
  2025-04-29 22:20 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Aryan Srivastava @ 2025-04-28 21:49 UTC (permalink / raw)
  To: Andrew Lunn
  Cc: Hans-Frieder Vogt, linux-kernel, netdev, Aryan Srivastava,
	kernel test robot

Comment was erroneously added with /**, amend this to use /* as it is
not a kernel-doc.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202504262247.1UBrDBVN-lkp@intel.com/
Signed-off-by: Aryan Srivastava <aryan.srivastava@alliedtelesis.co.nz>
---
 drivers/net/phy/aquantia/aquantia_main.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/net/phy/aquantia/aquantia_main.c b/drivers/net/phy/aquantia/aquantia_main.c
index 08b1c9cc902b..77a48635d7bf 100644
--- a/drivers/net/phy/aquantia/aquantia_main.c
+++ b/drivers/net/phy/aquantia/aquantia_main.c
@@ -516,8 +516,7 @@ static int aqr105_read_status(struct phy_device *phydev)
 	if (!phydev->link || phydev->autoneg == AUTONEG_DISABLE)
 		return 0;
 
-	/**
-	 * The status register is not immediately correct on line side link up.
+	/* The status register is not immediately correct on line side link up.
 	 * Poll periodically until it reflects the correct ON state.
 	 * Only return fail for read error, timeout defaults to OFF state.
 	 */
@@ -634,8 +633,7 @@ static int aqr107_read_status(struct phy_device *phydev)
 	if (!phydev->link || phydev->autoneg == AUTONEG_DISABLE)
 		return 0;
 
-	/**
-	 * The status register is not immediately correct on line side link up.
+	/* The status register is not immediately correct on line side link up.
 	 * Poll periodically until it reflects the correct ON state.
 	 * Only return fail for read error, timeout defaults to OFF state.
 	 */
-- 
2.49.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next v0] net: phy: aquantia: fix commenting format
  2025-04-28 21:49 [PATCH net-next v0] net: phy: aquantia: fix commenting format Aryan Srivastava
@ 2025-04-29 20:03 ` Simon Horman
  2025-04-29 22:20 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2025-04-29 20:03 UTC (permalink / raw)
  To: Aryan Srivastava
  Cc: Andrew Lunn, Hans-Frieder Vogt, linux-kernel, netdev,
	kernel test robot

On Tue, Apr 29, 2025 at 09:49:20AM +1200, Aryan Srivastava wrote:
> Comment was erroneously added with /**, amend this to use /* as it is
> not a kernel-doc.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202504262247.1UBrDBVN-lkp@intel.com/
> Signed-off-by: Aryan Srivastava <aryan.srivastava@alliedtelesis.co.nz>

Thanks.

Strangely ./scripts/kernel-doc -Wall -none has nothing to say about this.

But the file is clean in that respect (both before and after this change);
I agree this is correct; And I couldn't find any other instances of this
problem under rivers/net/phy/aquantia/

Reviewed-by: Simon Horman <horms@kernel.org>

...

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next v0] net: phy: aquantia: fix commenting format
  2025-04-28 21:49 [PATCH net-next v0] net: phy: aquantia: fix commenting format Aryan Srivastava
  2025-04-29 20:03 ` Simon Horman
@ 2025-04-29 22:20 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-04-29 22:20 UTC (permalink / raw)
  To: Aryan Srivastava; +Cc: andrew, hfdevel, linux-kernel, netdev, lkp

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Tue, 29 Apr 2025 09:49:20 +1200 you wrote:
> Comment was erroneously added with /**, amend this to use /* as it is
> not a kernel-doc.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202504262247.1UBrDBVN-lkp@intel.com/
> Signed-off-by: Aryan Srivastava <aryan.srivastava@alliedtelesis.co.nz>
> 
> [...]

Here is the summary with links:
  - [net-next,v0] net: phy: aquantia: fix commenting format
    https://git.kernel.org/netdev/net-next/c/aa6dcab1ea92

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-04-29 22:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-28 21:49 [PATCH net-next v0] net: phy: aquantia: fix commenting format Aryan Srivastava
2025-04-29 20:03 ` Simon Horman
2025-04-29 22:20 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).