From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-fw-6002.amazon.com (smtp-fw-6002.amazon.com [52.95.49.90]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7EDE0322A; Thu, 1 May 2025 03:19:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=52.95.49.90 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746069561; cv=none; b=H7nh6yhqySeBrJc0OtrNbJTP2f6JP1pp/yO3zcCr5qaZFGSN8o0hatoxn0SqLI3ySoxUlqWm3ANwvJC9/LlNO/6lEWNbPQsPS/RC4WIOe2eyoN6/4LM4ucSmZ+C610ugKcI34FdTZ70zHcYe70SWD+PkGgm21bIoiQrQ/jSBsUY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746069561; c=relaxed/simple; bh=RnGo3eVZ8Wcd8RXMAWNDmmrSdcERCG1DiTmcD2L68Os=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=D/gvgQXYbrLz5sJyHgUZ3YruwjrFbnpNhZxMd/Oe4fcADDYm5pzbK1LlgS4sBYbvUXAw18GUkf91BvcGNkrj4XVHe+DroGFq7caJgttFP1BCqryMOMb/M5py6u7jpmFTqrzqQ5xsUsOPR6d4jdD1+JgeCcYfhJgd6Zfw+wRP5rY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com; spf=pass smtp.mailfrom=amazon.co.jp; dkim=pass (1024-bit key) header.d=amazon.com header.i=@amazon.com header.b=Cqyp6Kiv; arc=none smtp.client-ip=52.95.49.90 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amazon.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amazon.com header.i=@amazon.com header.b="Cqyp6Kiv" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1746069560; x=1777605560; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=0jfy50eL43x6RabkD0VNeUvZqkKb2RUgwxKYds+fE2o=; b=Cqyp6KivDJ+pmMUd2ft+oMZ52BdtZL0VEFvVah+gK0M1AWjL9MMIoUP8 EZkgqd1n7uJo8epW9ZmkYWlWgH0MX1FZLSAeNJ6gm4M/dRv+Eqp09+7ig 62jxYl9JcbvD/sqZpGopgUV5TLGSNLwe1Hf102l1xtbN1olgJ6M3vBr+M 4=; X-IronPort-AV: E=Sophos;i="6.15,253,1739836800"; d="scan'208";a="494284256" Received: from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO smtpout.prod.us-west-2.prod.farcaster.email.amazon.dev) ([10.43.8.6]) by smtp-border-fw-6002.iad6.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 May 2025 03:19:15 +0000 Received: from EX19MTAUWA002.ant.amazon.com [10.0.21.151:56266] by smtpin.naws.us-west-2.prod.farcaster.email.amazon.dev [10.0.38.92:2525] with esmtp (Farcaster) id 6a9c4c01-a4bf-4386-a275-e61fc1e6a511; Thu, 1 May 2025 03:19:13 +0000 (UTC) X-Farcaster-Flow-ID: 6a9c4c01-a4bf-4386-a275-e61fc1e6a511 Received: from EX19D004ANA001.ant.amazon.com (10.37.240.138) by EX19MTAUWA002.ant.amazon.com (10.250.64.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.1544.14; Thu, 1 May 2025 03:19:13 +0000 Received: from 6c7e67bfbae3.amazon.com (10.187.171.60) by EX19D004ANA001.ant.amazon.com (10.37.240.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.1544.14; Thu, 1 May 2025 03:19:08 +0000 From: Kuniyuki Iwashima To: CC: , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v6 08/10] net: add symlinks to ref_tracker_dir for netns Date: Wed, 30 Apr 2025 20:07:56 -0700 Message-ID: <20250501031900.71399-1-kuniyu@amazon.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: EX19D040UWB004.ant.amazon.com (10.13.138.91) To EX19D004ANA001.ant.amazon.com (10.37.240.138) From: Jeff Layton Date: Wed, 30 Apr 2025 19:59:23 -0700 > On Wed, 2025-04-30 at 14:29 -0700, Kuniyuki Iwashima wrote: > > From: Jeff Layton > > Date: Wed, 30 Apr 2025 08:06:54 -0700 > > > After assigning the inode number to the namespace, use it to create a > > > unique name for each netns refcount tracker with the ns.inum value in > > > it, and register a symlink to the debugfs file for it. > > > > > > init_net is registered before the ref_tracker dir is created, so add a > > > late_initcall() to register its files and symlinks. > > > > > > Signed-off-by: Jeff Layton > > > --- > > > net/core/net_namespace.c | 28 +++++++++++++++++++++++++++- > > > 1 file changed, 27 insertions(+), 1 deletion(-) > > > > > > diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c > > > index 008de9675ea98fa8c18628b2f1c3aee7f3ebc9c6..6cbc8eabb8e56c847fc34fa8ec9994e8b275b0af 100644 > > > --- a/net/core/net_namespace.c > > > +++ b/net/core/net_namespace.c > > > @@ -763,12 +763,38 @@ struct net *get_net_ns_by_pid(pid_t pid) > > > } > > > EXPORT_SYMBOL_GPL(get_net_ns_by_pid); > > > > > > +#ifdef CONFIG_NET_NS_REFCNT_TRACKER > > > +static void net_ns_net_debugfs(struct net *net) > > > +{ > > > + ref_tracker_dir_symlink(&net->refcnt_tracker, "netns-%u-refcnt", net->ns.inum); > > > + ref_tracker_dir_symlink(&net->notrefcnt_tracker, "netns-%u-notrefcnt", net->ns.inum); > > > > Could you use net->net_cookie ? > > > > net->ns.inum is always 1 when CONFIG_PROC_FS=n. > > My main use-case for this is to be able to match the inode number in > the /proc//ns/net symlink with the correct ref_tracker debugfs > file. Is there a way to use the net_cookie to make that association? It's roundabout, but net_cookie can be retrieved by creating a random socket in the netns and calling setsockopt(SO_NETNS_COOKIE). Ido proposed a handy ip-netns subcommand here, and I guess it will be implemented soon(?) https://lore.kernel.org/netdev/1d99d7ccfc3a7a18840948ab6ba1c0b5fad90901.camel@fejes.dev/ > > If there isn't, and ns.inum is always 1 with procfs is disabled, we > could just skip adding the symlink when CONFIG_PROC_FS=n.