From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-fw-80006.amazon.com (smtp-fw-80006.amazon.com [99.78.197.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD1CB194080; Thu, 1 May 2025 03:51:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=99.78.197.217 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746071493; cv=none; b=SXOXZjXGAM0Hz54mEy/GpaINdjL2NI/izjZWRLopSj9Tff4I7qpdofR7ePD1JEjJy6H9Sm8ZFO+PBUF6nwUfsIea56SGHjb3+18U4U09F3Ajp25/+9EaDrONBoIexHZGIynkSr2L83OC6i65/+zVuLTTILlYMiRWRNBtmXE1k+I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746071493; c=relaxed/simple; bh=KVlMb35ubI+FQLca5L5hYJe3JN5pCP4/Z8oYHZx0BoA=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=HPnkfBsQFNs7DCGkl5ON8pdGUhk262ZTp9qMZ2Q/vA9LE69p7kFBPT0O29vNuYZo4SP/nx/FYNUFnabvpjlqlmP3QLCqAVaiO/qX/MJfDV8cXiHvS43E4O6WEe5T6rlYMr1ubnth0CtvvI8g4CfT3zLU+kIjFiLBA1vD9t+gy5g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com; spf=pass smtp.mailfrom=amazon.co.jp; dkim=pass (1024-bit key) header.d=amazon.com header.i=@amazon.com header.b=Uog9HKG9; arc=none smtp.client-ip=99.78.197.217 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amazon.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amazon.com header.i=@amazon.com header.b="Uog9HKG9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1746071492; x=1777607492; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ieN6Uufg5eN4Yl9eD7qnOlPh9TDKaa21BdQlQv6AVLs=; b=Uog9HKG9oX89jZ0z8OkNZc5M8dq/NqX+UWudZm4ypCdF8Xgv+I6koDWe DHiXHw9KVj8ExIkn2F8W/oX4aKC5JJsBUBJ4APhwfkj8bf0N+8F2OYrSa OlgsLsdGA6J/0TlgEUtktoTS9clpazhlv9APdSh1pOE85dkzAFqD38Sww M=; X-IronPort-AV: E=Sophos;i="6.15,253,1739836800"; d="scan'208";a="45594019" Received: from pdx4-co-svc-p1-lb2-vlan3.amazon.com (HELO smtpout.prod.us-west-2.prod.farcaster.email.amazon.dev) ([10.25.36.214]) by smtp-border-fw-80006.pdx80.corp.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 May 2025 03:51:30 +0000 Received: from EX19MTAUWC001.ant.amazon.com [10.0.21.151:42164] by smtpin.naws.us-west-2.prod.farcaster.email.amazon.dev [10.0.59.114:2525] with esmtp (Farcaster) id 7bc7e118-2ba3-4338-9316-07c9580be08c; Thu, 1 May 2025 03:51:29 +0000 (UTC) X-Farcaster-Flow-ID: 7bc7e118-2ba3-4338-9316-07c9580be08c Received: from EX19D004ANA001.ant.amazon.com (10.37.240.138) by EX19MTAUWC001.ant.amazon.com (10.250.64.174) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.1544.14; Thu, 1 May 2025 03:51:28 +0000 Received: from 6c7e67bfbae3.amazon.com (10.187.171.60) by EX19D004ANA001.ant.amazon.com (10.37.240.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.1544.14; Thu, 1 May 2025 03:51:23 +0000 From: Kuniyuki Iwashima To: CC: , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v6 08/10] net: add symlinks to ref_tracker_dir for netns Date: Wed, 30 Apr 2025 20:50:49 -0700 Message-ID: <20250501035115.76182-1-kuniyu@amazon.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: EX19D045UWC001.ant.amazon.com (10.13.139.223) To EX19D004ANA001.ant.amazon.com (10.37.240.138) From: Jeff Layton Date: Wed, 30 Apr 2025 20:42:40 -0700 > On Wed, 2025-04-30 at 20:07 -0700, Kuniyuki Iwashima wrote: > > From: Jeff Layton > > Date: Wed, 30 Apr 2025 19:59:23 -0700 > > > On Wed, 2025-04-30 at 14:29 -0700, Kuniyuki Iwashima wrote: > > > > From: Jeff Layton > > > > Date: Wed, 30 Apr 2025 08:06:54 -0700 > > > > > After assigning the inode number to the namespace, use it to create a > > > > > unique name for each netns refcount tracker with the ns.inum value in > > > > > it, and register a symlink to the debugfs file for it. > > > > > > > > > > init_net is registered before the ref_tracker dir is created, so add a > > > > > late_initcall() to register its files and symlinks. > > > > > > > > > > Signed-off-by: Jeff Layton > > > > > --- > > > > > net/core/net_namespace.c | 28 +++++++++++++++++++++++++++- > > > > > 1 file changed, 27 insertions(+), 1 deletion(-) > > > > > > > > > > diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c > > > > > index 008de9675ea98fa8c18628b2f1c3aee7f3ebc9c6..6cbc8eabb8e56c847fc34fa8ec9994e8b275b0af 100644 > > > > > --- a/net/core/net_namespace.c > > > > > +++ b/net/core/net_namespace.c > > > > > @@ -763,12 +763,38 @@ struct net *get_net_ns_by_pid(pid_t pid) > > > > > } > > > > > EXPORT_SYMBOL_GPL(get_net_ns_by_pid); > > > > > > > > > > +#ifdef CONFIG_NET_NS_REFCNT_TRACKER > > > > > +static void net_ns_net_debugfs(struct net *net) > > > > > +{ > > > > > + ref_tracker_dir_symlink(&net->refcnt_tracker, "netns-%u-refcnt", net->ns.inum); > > > > > + ref_tracker_dir_symlink(&net->notrefcnt_tracker, "netns-%u-notrefcnt", net->ns.inum); > > > > > > > > Could you use net->net_cookie ? > > > > > > > > net->ns.inum is always 1 when CONFIG_PROC_FS=n. > > > > > > My main use-case for this is to be able to match the inode number in > > > the /proc//ns/net symlink with the correct ref_tracker debugfs > > > file. Is there a way to use the net_cookie to make that association? > > > > It's roundabout, but net_cookie can be retrieved by creating a > > random socket in the netns and calling setsockopt(SO_NETNS_COOKIE). > > > > Ido proposed a handy ip-netns subcommand here, and I guess it will > > be implemented soon(?) > > https://lore.kernel.org/netdev/1d99d7ccfc3a7a18840948ab6ba1c0b5fad90901.camel@fejes.dev/ > > For the cases where I was looking at netns leaks, there were no more > processes in the container, so there was no way to enter the container > and spawn a socket at that point. Then how do you get net->ns.inum ? > > The point of the symlinks is to have a way to easily identify what > you're tracking. NAME_MAX is 255. We could do something like this > instead: > > snprintf(..., "netns-%u-%llx-refcnt", net->ns.inum, net->net_cookie); > > Obviously the inums would all be 1 when PROC_FS=n, but the cookies > would be unique. Would that work? This works, but depending on the question above, there's no point in using inum ?