From: Jakub Kicinski <kuba@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>
Cc: Edward Cree <ecree.xilinx@gmail.com>,
davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
andrew+netdev@lunn.ch, horms@kernel.org, petrm@nvidia.com,
willemb@google.com, sdf@fomichev.me,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next v2] selftests: net: exit cleanly on SIGTERM / timeout
Date: Fri, 2 May 2025 18:13:20 -0700 [thread overview]
Message-ID: <20250502181320.562940c0@kernel.org> (raw)
In-Reply-To: <f94dc055-6c3b-4fae-868a-723f9dc63db5@redhat.com>
On Fri, 2 May 2025 15:05:48 +0200 Paolo Abeni wrote:
> >> @@ -229,11 +249,12 @@ KSFT_DISRUPTIVE = True
> >> cnt_key = 'xfail'
> >> except BaseException as e:
> >> stop |= isinstance(e, KeyboardInterrupt)
> >> + stop |= isinstance(e, KsftTerminate)
> >
> > The first isinstance() will return True for a KsftTerminate as it's a
> > subclass of KeyboardInterrupt, and thus the second line isn't needed.
>
> @Jakub: I'm using the selftests code to refresh my rather rusty python
> skills, I think it would be good to address the above and keep the
> codebase clean.
Right, right, I was just distracted the last 3 days, wasn't trying
to ignore :) Will respin shortly, good catch indeed.
prev parent reply other threads:[~2025-05-03 1:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-29 17:08 [PATCH net-next v2] selftests: net: exit cleanly on SIGTERM / timeout Jakub Kicinski
2025-04-29 17:34 ` Willem de Bruijn
2025-04-30 18:03 ` Edward Cree
2025-05-02 13:05 ` Paolo Abeni
2025-05-03 1:13 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250502181320.562940c0@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=sdf@fomichev.me \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).