Re: [PATCH net-next 3/5] devlink: define enum for attr types of dynamic attributes

[Jakub Kicinski <kuba@kernel.org>]

On Fri,  2 May 2025 13:38:19 +0200 Jiri Pirko wrote:
> +/**
> + * enum devlink_var_attr_type - Variable attribute type.
> + */

If we want this to be a kdoc it needs to document all values.
Same as a struct kdoc needs to document all values.
Not sure if there's much to say here for each value, so a non-kdoc
comment is probably better?

I think I already mentioned this generates a build warning..

> +enum devlink_var_attr_type {
> +	/* Following values relate to the internal NLA_* values */
> +	DEVLINK_VAR_ATTR_TYPE_U8 = 1,
> +	DEVLINK_VAR_ATTR_TYPE_U16,
> +	DEVLINK_VAR_ATTR_TYPE_U32,
> +	DEVLINK_VAR_ATTR_TYPE_U64,
> +	DEVLINK_VAR_ATTR_TYPE_STRING,
> +	DEVLINK_VAR_ATTR_TYPE_FLAG,
> +	DEVLINK_VAR_ATTR_TYPE_NUL_STRING = 10,
> +	DEVLINK_VAR_ATTR_TYPE_BINARY,
> +	__DEVLINK_VAR_ATTR_TYPE_CUSTOM_BASE = 0x80,
> +	/* Any possible custom types, unrelated to NLA_* values go below */
> +};