[PATCH net-next] eth: fbnic: fix `tx_dropped` counting

[PATCH net-next] eth: fbnic: fix `tx_dropped` counting

[Mohsin Bashir]

Fix the tracking of rtnl_link_stats.tx_dropped. The counter
`tmi.drop.frames` is being double counted whereas, the counter
`tti.cm_drop.frames` is being skipped.

Fixes: f2957147ae7a ("eth: fbnic: add support for TTI HW stats")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Mohsin Bashir <mohsin.bashr@gmail.com>
---
 drivers/net/ethernet/meta/fbnic/fbnic_netdev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_netdev.c b/drivers/net/ethernet/meta/fbnic/fbnic_netdev.c
index d699f58dda21..f994cbf1857d 100644
--- a/drivers/net/ethernet/meta/fbnic/fbnic_netdev.c
+++ b/drivers/net/ethernet/meta/fbnic/fbnic_netdev.c
@@ -425,9 +425,9 @@ static void fbnic_get_stats64(struct net_device *dev,
 
 	/* Record drops from Tx HW Datapath */
 	tx_dropped += fbd->hw_stats.tmi.drop.frames.value +
+		      fbd->hw_stats.tti.cm_drop.frames.value +
 		      fbd->hw_stats.tti.frame_drop.frames.value +
-		      fbd->hw_stats.tti.tbi_drop.frames.value +
-		      fbd->hw_stats.tmi.drop.frames.value;
+		      fbd->hw_stats.tti.tbi_drop.frames.value;
 
 	for (i = 0; i < fbn->num_tx_queues; i++) {
 		struct fbnic_ring *txr = fbn->tx[i];
-- 
2.47.1

Re: [PATCH net-next] eth: fbnic: fix `tx_dropped` counting

[Joe Damato]

On Fri, May 02, 2025 at 07:01:45PM -0700, Mohsin Bashir wrote:
> Fix the tracking of rtnl_link_stats.tx_dropped. The counter
> `tmi.drop.frames` is being double counted whereas, the counter
> `tti.cm_drop.frames` is being skipped.
> 
> Fixes: f2957147ae7a ("eth: fbnic: add support for TTI HW stats")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: Mohsin Bashir <mohsin.bashr@gmail.com>
> ---
>  drivers/net/ethernet/meta/fbnic/fbnic_netdev.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Joe Damato <jdamato@fastly.com>

Re: [PATCH net-next] eth: fbnic: fix `tx_dropped` counting

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Fri,  2 May 2025 19:01:45 -0700 you wrote:
> Fix the tracking of rtnl_link_stats.tx_dropped. The counter
> `tmi.drop.frames` is being double counted whereas, the counter
> `tti.cm_drop.frames` is being skipped.
> 
> Fixes: f2957147ae7a ("eth: fbnic: add support for TTI HW stats")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: Mohsin Bashir <mohsin.bashr@gmail.com>
> 
> [...]

Here is the summary with links:
  - [net-next] eth: fbnic: fix `tx_dropped` counting
    https://git.kernel.org/netdev/net-next/c/fbaeb7b0f0ff

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html