From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C35E33635ED for ; Mon, 5 May 2025 22:51:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746485492; cv=none; b=XifsA/n6HssC+D9R9hRugDakz0nfH5bIbN7YzBVXta3CUQjJZ6ZfijRFHr5VBunayN95zAh3wrcc+lvQOawEVQF0BUkNnECcODXXLfdspcQ4wUNEeQHAaUc5vXsgB/gLV+bUc2bU4nMEHEEgVknypcO/j+b0kGgHrwThi2nzeic= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746485492; c=relaxed/simple; bh=Fv7tOcmIH8k0UEu1oeq8fVLRh8TtLCZmxeQiaSFWbC8=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Teahvwnzg1s9inCuUFkEBS7PxbmCmqTlCBmzhf5FDoPG0/n5NCBZ7fYwjawEW7/4Li1LJc1ENa4d8bXYm1YXWE65jMD8YjfzuQfREca5J5C2BA4vvaAy2MdEtw78IWkPPZ1cGCA2tOT6xJ18t+/kdZwWsn7T60cdKWN4wac1IjM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=K9fXRjxE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="K9fXRjxE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 11D43C4CEED; Mon, 5 May 2025 22:51:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746485491; bh=Fv7tOcmIH8k0UEu1oeq8fVLRh8TtLCZmxeQiaSFWbC8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=K9fXRjxE/jzp5T7JufShItC4QtV89AbCu62dyrao4T8eJBhlslig3WFvxOiCnt9S3 aRUxeT7OZ+KDt1ZB5u1dwVUgjO5jcUMdJUr2ngmK2HyFmG4Ml1ot/Zw5W9moid9esS uH5uCsuBVetm7EaMgdJ9FbKpMWwz5ew45ZV4mphYUKkhxYkbkEUnpVf742v34kFDD1 qo6T2vhdRMEN07HBOeiR+JuiNWpcopTUix94McNnMA2CsosqLWJB6P3lQPGojtgqsb h3PNA6ojCnaFt2gZicjTjPDCqz/rvabBMmmnGouGPYQQEBILXYAsaTZ/6hXwxud6VD euZFM89CYCaVg== Date: Mon, 5 May 2025 15:51:30 -0700 From: Jakub Kicinski To: Keith Busch Cc: Gustavo Padovan , Aurelien Aptel , linux-nvme , netdev , sagi , hch , axboe , chaitanyak , davem , "aurelien.aptel" , smalin , malin1024 , ogerlitz , yorayz , borisp , galshalom , mgurtovoy , tariqt , edumazet Subject: Re: [PATCH v28 00/20] nvme-tcp receive offloads Message-ID: <20250505155130.6e588cdf@kernel.org> In-Reply-To: References: <20250430085741.5108-1-aaptel@nvidia.com> <19686c19e11.ba39875d3947402.7647787744422691035@collabora.com> <20250505134334.28389275@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 5 May 2025 15:51:15 -0600 Keith Busch wrote: > On Mon, May 05, 2025 at 01:43:34PM -0700, Jakub Kicinski wrote: > > Looks like the tests passed? But we'll drop this from our PW, again. > > Christoph Hellwig was pushing back on the v27. We can't do anything > > with these until NVMe people are all happy. > > FWIW, I believe Sagi is okay with this as he has reviewed or acked all > the patches. I am also okay with this, though I'm more or less neutral > on the whole since it's outside my scope, but the nvme parts look fine. > The new additions are isolated to hardware that provides these offloads, > so I'm not really concerned this is going to be a problem maintaining > with the existing nvme-tcp driver. I trust in Sagi on this one. Thanks, so we have two "yes" votes. Let's give it a week and if there are no vetoes / nacks we can start.. chasing TCP maintainers for an ack?