From: Jakub Kicinski <kuba@kernel.org>
To: Mina Almasry <almasrymina@google.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, io-uring@vger.kernel.org,
virtualization@lists.linux.dev, kvm@vger.kernel.org,
linux-kselftest@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Simon Horman" <horms@kernel.org>,
"Donald Hunter" <donald.hunter@gmail.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"Jeroen de Borst" <jeroendb@google.com>,
"Harshitha Ramamurthy" <hramamurthy@google.com>,
"Kuniyuki Iwashima" <kuniyu@amazon.com>,
"Willem de Bruijn" <willemb@google.com>,
"Jens Axboe" <axboe@kernel.dk>,
"Pavel Begunkov" <asml.silence@gmail.com>,
"David Ahern" <dsahern@kernel.org>,
"Neal Cardwell" <ncardwell@google.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"Eugenio Pérez" <eperezma@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Stefano Garzarella" <sgarzare@redhat.com>,
"Shuah Khan" <shuah@kernel.org>,
sdf@fomichev.me, dw@davidwei.uk,
"Jamal Hadi Salim" <jhs@mojatatu.com>,
"Victor Nogueira" <victor@mojatatu.com>,
"Pedro Tammela" <pctammela@mojatatu.com>,
"Samiullah Khawaja" <skhawaja@google.com>,
"Kaiyuan Zhang" <kaiyuanz@google.com>
Subject: Re: [PATCH net-next v13 4/9] net: devmem: Implement TX path
Date: Mon, 5 May 2025 18:37:58 -0700 [thread overview]
Message-ID: <20250505183758.7778811c@kernel.org> (raw)
In-Reply-To: <20250429032645.363766-5-almasrymina@google.com>
Functionally LGTM. But I'm not sure if the discussion with Paolo is
resolved, so here's a couple more nit picks:
On Tue, 29 Apr 2025 03:26:40 +0000 Mina Almasry wrote:
> + case SCM_DEVMEM_DMABUF:
> + if (cmsg->cmsg_len != CMSG_LEN(sizeof(u32)))
> + return -EINVAL;
> + sockc->dmabuf_id = *(u32 *)CMSG_DATA(cmsg);
> +
> break;
The empty line before break is very odd.
> + sockc = (struct sockcm_cookie){ .tsflags = READ_ONCE(sk->sk_tsflags),
> + .dmabuf_id = 0 };
Too ugly to exist, either full init fits on a line or there needs to be
a line break after {.
next prev parent reply other threads:[~2025-05-06 1:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-29 3:26 [PATCH net-next v13 0/9] Device memory TCP TX Mina Almasry
2025-04-29 3:26 ` [PATCH net-next v13 1/9] netmem: add niov->type attribute to distinguish different net_iov types Mina Almasry
2025-04-29 3:26 ` [PATCH net-next v13 2/9] net: add get_netmem/put_netmem support Mina Almasry
2025-04-29 3:26 ` [PATCH net-next v13 3/9] net: devmem: TCP tx netlink api Mina Almasry
2025-04-29 3:26 ` [PATCH net-next v13 4/9] net: devmem: Implement TX path Mina Almasry
2025-05-02 11:47 ` Paolo Abeni
2025-05-02 11:51 ` Paolo Abeni
2025-05-02 19:25 ` Mina Almasry
2025-05-05 7:37 ` Paolo Abeni
2025-05-02 19:20 ` Mina Almasry
2025-05-05 7:36 ` Paolo Abeni
2025-05-05 19:21 ` Mina Almasry
2025-05-06 1:37 ` Jakub Kicinski [this message]
2025-04-29 3:26 ` [PATCH net-next v13 5/9] net: add devmem TCP TX documentation Mina Almasry
2025-04-29 3:26 ` [PATCH net-next v13 6/9] net: enable driver support for netmem TX Mina Almasry
2025-04-29 3:26 ` [PATCH net-next v13 7/9] gve: add netmem TX support to GVE DQO-RDA mode Mina Almasry
2025-04-29 3:26 ` [PATCH net-next v13 8/9] net: check for driver support in netmem TX Mina Almasry
2025-04-29 3:26 ` [PATCH net-next v13 9/9] selftests: ncdevmem: Implement devmem TCP TX Mina Almasry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250505183758.7778811c@kernel.org \
--to=kuba@kernel.org \
--cc=almasrymina@google.com \
--cc=andrew+netdev@lunn.ch \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=dsahern@kernel.org \
--cc=dw@davidwei.uk \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=horms@kernel.org \
--cc=hramamurthy@google.com \
--cc=io-uring@vger.kernel.org \
--cc=jasowang@redhat.com \
--cc=jeroendb@google.com \
--cc=jhs@mojatatu.com \
--cc=kaiyuanz@google.com \
--cc=kuniyu@amazon.com \
--cc=kvm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mst@redhat.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pctammela@mojatatu.com \
--cc=sdf@fomichev.me \
--cc=sgarzare@redhat.com \
--cc=shuah@kernel.org \
--cc=skhawaja@google.com \
--cc=stefanha@redhat.com \
--cc=victor@mojatatu.com \
--cc=virtualization@lists.linux.dev \
--cc=willemb@google.com \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).