From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: davem@davemloft.net
Cc: "Maxime Chevallier" <maxime.chevallier@bootlin.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, thomas.petazzoni@bootlin.com,
"Andrew Lunn" <andrew@lunn.ch>,
"Jakub Kicinski" <kuba@kernel.org>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Russell King" <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Herve Codina" <herve.codina@bootlin.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Vladimir Oltean" <vladimir.oltean@nxp.com>,
"Köry Maincent" <kory.maincent@bootlin.com>,
"Marek Behún" <kabel@kernel.org>,
"Oleksij Rempel" <o.rempel@pengutronix.de>,
"Nicolò Veronese" <nicveronese@gmail.com>,
"Simon Horman" <horms@kernel.org>,
mwojtas@chromium.org, "Antoine Tenart" <atenart@kernel.org>,
devicetree@vger.kernel.org, "Conor Dooley" <conor+dt@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Romain Gantois" <romain.gantois@bootlin.com>,
"Daniel Golle" <daniel@makrotopia.org>,
"Dimitri Fedrau" <dimitri.fedrau@liebherr.com>
Subject: [PATCH net-next v6 13/14] net: phy: dp83822: Add SFP support through the phy_port interface
Date: Wed, 7 May 2025 15:53:29 +0200 [thread overview]
Message-ID: <20250507135331.76021-14-maxime.chevallier@bootlin.com> (raw)
In-Reply-To: <20250507135331.76021-1-maxime.chevallier@bootlin.com>
The DP83822 can support 100BaseFX. This mode was only accessible through
custom DT properties, but there also exist SFP modules that support
these modes. As this only requires setting the relevant supported
interface in the driver, expose the port capability with the new
phy_port API, allowing SFP support.
Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
---
drivers/net/phy/dp83822.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/net/phy/dp83822.c b/drivers/net/phy/dp83822.c
index a0b4ebddd484..194de35bd064 100644
--- a/drivers/net/phy/dp83822.c
+++ b/drivers/net/phy/dp83822.c
@@ -982,6 +982,13 @@ static int dp83822_attach_port(struct phy_device *phydev, struct phy_port *port)
}
}
+ /* If attached from SFP, is_serdes is set, but not the mediums. */
+ if (port->is_serdes)
+ dp83822->fx_enabled = true;
+
+ if (dp83822->fx_enabled)
+ __set_bit(PHY_INTERFACE_MODE_100BASEX, port->interfaces);
+
return 0;
}
--
2.49.0
next prev parent reply other threads:[~2025-05-07 13:54 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-07 13:53 [PATCH net-next v6 00/14] Introduce an ethernet port representation Maxime Chevallier
2025-05-07 13:53 ` [PATCH net-next v6 01/14] dt-bindings: net: Introduce the ethernet-connector description Maxime Chevallier
2025-05-13 13:08 ` Kory Maincent
2025-05-07 13:53 ` [PATCH net-next v6 02/14] net: ethtool: Introduce ETHTOOL_LINK_MEDIUM_* values Maxime Chevallier
2025-05-07 13:53 ` [PATCH net-next v6 03/14] net: phy: Introduce PHY ports representation Maxime Chevallier
2025-05-12 7:53 ` Romain Gantois
2025-06-27 16:54 ` Maxime Chevallier
2025-05-13 13:53 ` Kory Maincent
2025-06-27 17:02 ` Maxime Chevallier
2025-05-07 13:53 ` [PATCH net-next v6 04/14] net: phy: dp83822: Add support for phy_port representation Maxime Chevallier
2025-05-13 14:00 ` Kory Maincent
2025-05-07 13:53 ` [PATCH net-next v6 05/14] net: phy: Create a phy_port for PHY-driven SFPs Maxime Chevallier
2025-05-13 12:25 ` Romain Gantois
2025-06-27 17:06 ` Maxime Chevallier
2025-05-07 13:53 ` [PATCH net-next v6 06/14] net: phy: Introduce generic SFP handling for PHY drivers Maxime Chevallier
2025-05-12 8:38 ` Romain Gantois
2025-05-23 12:54 ` Maxime Chevallier
2025-05-28 7:35 ` Romain Gantois
2025-05-28 8:14 ` Maxime Chevallier
2025-05-28 8:16 ` Romain Gantois
2025-05-29 13:23 ` Russell King (Oracle)
2025-05-30 7:28 ` Romain Gantois
2025-05-30 7:46 ` Russell King (Oracle)
2025-05-30 9:08 ` Romain Gantois
2025-05-07 13:53 ` [PATCH net-next v6 07/14] net: phy: marvell-88x2222: Support SFP through phy_port interface Maxime Chevallier
2025-05-07 13:53 ` [PATCH net-next v6 08/14] net: phy: marvell: " Maxime Chevallier
2025-05-07 13:53 ` [PATCH net-next v6 09/14] net: phy: marvell10g: Support SFP through phy_port Maxime Chevallier
2025-05-07 13:53 ` [PATCH net-next v6 10/14] net: phy: at803x: Support SFP through phy_port interface Maxime Chevallier
2025-05-07 13:53 ` [PATCH net-next v6 11/14] net: phy: qca807x: " Maxime Chevallier
2025-05-07 13:53 ` [PATCH net-next v6 12/14] net: phy: Only rely on phy_port for PHY-driven SFP Maxime Chevallier
2025-05-12 8:52 ` Romain Gantois
2025-05-07 13:53 ` Maxime Chevallier [this message]
2025-05-07 13:53 ` [PATCH net-next v6 14/14] Documentation: networking: Document the phy_port infrastructure Maxime Chevallier
2025-05-12 9:22 ` Romain Gantois
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250507135331.76021-14-maxime.chevallier@bootlin.com \
--to=maxime.chevallier@bootlin.com \
--cc=andrew@lunn.ch \
--cc=atenart@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=conor+dt@kernel.org \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dimitri.fedrau@liebherr.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=herve.codina@bootlin.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=kabel@kernel.org \
--cc=kory.maincent@bootlin.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mwojtas@chromium.org \
--cc=netdev@vger.kernel.org \
--cc=nicveronese@gmail.com \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=romain.gantois@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).