Re: [PATCH v14 08/22] sfc: initialize dpa

[Jonathan Cameron <Jonathan.Cameron@huawei.com>]

On Thu, 17 Apr 2025 22:29:11 +0100
<alejandro.lucero-palau@amd.com> wrote:

> From: Alejandro Lucero <alucerop@amd.com>
> 
> Use hardcoded values for defining and initializing dpa as there is no
> mbox available.
> 
> Signed-off-by: Alejandro Lucero <alucerop@amd.com>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

SFC / net.  If this might go through the CXL tree we need some tags
to say it looks good to you.

> ---
>  drivers/net/ethernet/sfc/efx_cxl.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/net/ethernet/sfc/efx_cxl.c b/drivers/net/ethernet/sfc/efx_cxl.c
> index 79427a85a1b7..e8bfaf7641e4 100644
> --- a/drivers/net/ethernet/sfc/efx_cxl.c
> +++ b/drivers/net/ethernet/sfc/efx_cxl.c
> @@ -23,6 +23,9 @@ int efx_cxl_init(struct efx_probe_data *probe_data)
>  	DECLARE_BITMAP(found, CXL_MAX_CAPS) = {};
>  	struct efx_nic *efx = &probe_data->efx;
>  	struct pci_dev *pci_dev = efx->pci_dev;
> +	struct cxl_dpa_info sfc_dpa_info = {
> +		.size = EFX_CTPIO_BUFFER_SIZE
> +	};
>  	struct efx_cxl *cxl;
>  	u16 dvsec;
>  	int rc;
> @@ -70,6 +73,11 @@ int efx_cxl_init(struct efx_probe_data *probe_data)
>  	 */
>  	cxl->cxlds.media_ready = true;
>  
> +	cxl_mem_dpa_init(&sfc_dpa_info, EFX_CTPIO_BUFFER_SIZE, 0);
> +	rc = cxl_dpa_setup(&cxl->cxlds, &sfc_dpa_info);
> +	if (rc)
> +		return rc;
> +
>  	probe_data->cxl = cxl;
>  
>  	return 0;