From: Jakub Kicinski <kuba@kernel.org>
To: Jesper Dangaard Brouer <hawk@kernel.org>
Cc: Jon Kohler <jon@nutanix.com>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Zvi Effron <zeffron@riotgames.com>,
Stanislav Fomichev <stfomichev@gmail.com>,
Jason Wang <jasowang@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
John Fastabend <john.fastabend@gmail.com>,
Simon Horman <horms@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
Jacob Keller <jacob.e.keller@intel.com>
Subject: Re: [PATCH net-next v3] xdp: Add helpers for head length, headroom, and metadata length
Date: Wed, 7 May 2025 17:18:29 -0700 [thread overview]
Message-ID: <20250507171829.3e8f8a76@kernel.org> (raw)
In-Reply-To: <b99b73e8-0957-45f8-bd54-6c50640706df@kernel.org>
On Wed, 7 May 2025 22:58:33 +0200 Jesper Dangaard Brouer wrote:
> > There is a neat hint from Lorenzo’s change in bpf.h for bpf_xdp_get_buff_len()
> > that talks about both linear and paged length. Also, xdp_buff_flags’s
> > XDP_FLAGS_HAS_FRAGS says non-linear xdp buff.
> >
> > Taking those hints, what about:
> > xdp_linear_len() == xdp->data_end - xdp->data
> > xdp_paged_len() == sinfo->xdp_frags_size
> > xdp_get_buff_len() == xdp_linear_len() + xdp_paged_len()
>
> I like xdp_linear_len() as it is descriptive/clear.
FWIW I don't feel strongly but my very weak preference would be
not to merge this. I already know I'll be looking at the definitions
every time. Is it obvious to everyone in this thread whether "headroom"
includes the metadata length? It's not obvious to me. But the patch
seems quite popular so 🤷️
next prev parent reply other threads:[~2025-05-08 0:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-06 12:52 [PATCH net-next v3] xdp: Add helpers for head length, headroom, and metadata length Jon Kohler
2025-05-06 17:43 ` Stanislav Fomichev
2025-05-07 13:29 ` Willem de Bruijn
2025-05-07 16:35 ` Jesper Dangaard Brouer
2025-05-07 17:02 ` Zvi Effron
2025-05-07 17:08 ` Jesper Dangaard Brouer
2025-05-07 17:21 ` Willem de Bruijn
2025-05-07 17:47 ` Jon Kohler
2025-05-07 19:04 ` Jesper Dangaard Brouer
2025-05-07 19:57 ` Jon Kohler
2025-05-07 20:58 ` Jesper Dangaard Brouer
2025-05-08 0:18 ` Jakub Kicinski [this message]
2025-05-08 3:19 ` Jon Kohler
2025-05-09 1:28 ` Jakub Kicinski
2025-05-08 3:18 ` Jon Kohler
2025-05-08 16:59 ` Jesper Dangaard Brouer
2025-05-09 1:26 ` Jakub Kicinski
2025-05-07 16:18 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250507171829.3e8f8a76@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=jasowang@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=jon@nutanix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stfomichev@gmail.com \
--cc=willemdebruijn.kernel@gmail.com \
--cc=zeffron@riotgames.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).