From: Jakub Kicinski <kuba@kernel.org>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
andrew+netdev@lunn.ch, jgg@ziepe.ca, leon@kernel.org,
linux-rdma@vger.kernel.org, netdev@vger.kernel.org,
Dave Ertman <david.m.ertman@intel.com>,
tatyana.e.nikolova@intel.com, przemyslaw.kitszel@intel.com
Subject: Re: [PATCH net-next,rdma-next 5/5] iidc/ice/irdma: Update IDC to support multiple consumers
Date: Wed, 7 May 2025 19:43:08 -0700 [thread overview]
Message-ID: <20250507194308.26d31e9a@kernel.org> (raw)
In-Reply-To: <20250505212037.2092288-6-anthony.l.nguyen@intel.com>
On Mon, 5 May 2025 14:20:34 -0700 Tony Nguyen wrote:
> - pf->rdma_mode |= IIDC_RDMA_PROTOCOL_ROCEV2;
> + cdev->iidc_priv = privd;
> + privd->netdev = pf->vsi[0]->netdev;
> +
> + privd->hw_addr = (u8 __iomem *)pf->hw.hw_addr;
> + cdev->pdev = pf->pdev;
> + privd->vport_id = pf->vsi[0]->vsi_num;
> +
> + pf->cdev_info->rdma_protocol |= IIDC_RDMA_PROTOCOL_ROCEV2;
> + ice_setup_dcb_qos_info(pf, &privd->qos_info);
> ret = ice_plug_aux_dev(pf);
> if (ret)
> goto err_plug_aux_dev;
> return 0;
>
> err_plug_aux_dev:
> - pf->adev = NULL;
> + pf->cdev_info->adev = NULL;
> xa_erase(&ice_aux_id, pf->aux_idx);
> +err_alloc_xa:
> + kfree(privd);
> +err_privd_alloc:
> + kfree(cdev);
> + pf->cdev_info = NULL;
Where do privd and cdev get freed on normal device removal?
next prev parent reply other threads:[~2025-05-08 2:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-05 21:20 [PATCH net-next,rdma-next 0/5][pull request] Prepare for Intel IPU E2000 (GEN3) Tony Nguyen
2025-05-05 21:20 ` [PATCH net-next,rdma-next 1/5] iidc/ice/irdma: Rename IDC header file Tony Nguyen
2025-05-05 21:20 ` [PATCH net-next,rdma-next 2/5] iidc/ice/irdma: Rename to iidc_* convention Tony Nguyen
2025-05-05 21:20 ` [PATCH net-next,rdma-next 3/5] iidc/ice/irdma: Break iidc.h into two headers Tony Nguyen
2025-05-05 21:20 ` [PATCH net-next,rdma-next 4/5] ice: Replace ice specific DSCP mapping num with a kernel define Tony Nguyen
2025-05-05 21:20 ` [PATCH net-next,rdma-next 5/5] iidc/ice/irdma: Update IDC to support multiple consumers Tony Nguyen
2025-05-08 2:43 ` Jakub Kicinski [this message]
2025-05-08 23:20 ` Ertman, David M
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250507194308.26d31e9a@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=david.m.ertman@intel.com \
--cc=edumazet@google.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=tatyana.e.nikolova@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).