From: Jakub Kicinski <kuba@kernel.org>
To: <Thangaraj.S@microchip.com>
Cc: <Bryan.Whitehead@microchip.com>, <andrew+netdev@lunn.ch>,
<davem@davemloft.net>, <andrew@lunn.ch>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<pabeni@redhat.com>, <edumazet@google.com>,
<UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH v1 net-next] net: lan743x: configure interrupt moderation timers based on speed
Date: Thu, 8 May 2025 06:54:19 -0700 [thread overview]
Message-ID: <20250508065419.2a089eba@kernel.org> (raw)
In-Reply-To: <32159cd4a320a492fd47b6c38cebdb9a994c8bf5.camel@microchip.com>
On Thu, 8 May 2025 03:36:17 +0000 Thangaraj.S@microchip.com wrote:
> I agree with your comments and will implement the ethtool option to
> provide flexibility, while keeping the default behavior as defined in
> this patch based on speed.
Why the speed based defaults? Do other vendors do that?
330usec is a very high latency, and if the link is running
at 10M we probably don't need IRQ moderation at all?
For Tx deferring the completion based on link speed makes sense.
We want an IRQ for a fixed amount of data, doesn't matter how
fast its going out. But for Rx the more aggressive the moderation
the higher the latency. In my experience the Rx moderation should
not depend on link speed.
reminder: please avoid top posting
next prev parent reply other threads:[~2025-05-08 13:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-05 7:29 [PATCH v1 net-next] net: lan743x: configure interrupt moderation timers based on speed Thangaraj Samynathan
2025-05-05 12:15 ` Andrew Lunn
2025-05-06 4:02 ` Thangaraj.S
2025-05-06 12:10 ` Andrew Lunn
2025-05-07 0:54 ` Jakub Kicinski
2025-05-08 3:36 ` Thangaraj.S
2025-05-08 13:54 ` Jakub Kicinski [this message]
2025-05-09 1:56 ` Ronnie.Kunin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250508065419.2a089eba@kernel.org \
--to=kuba@kernel.org \
--cc=Bryan.Whitehead@microchip.com \
--cc=Thangaraj.S@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).