From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Cc: netdev@vger.kernel.org,
"Köry Maincent" <kory.maincent@bootlin.com>,
"Kurt Kanzenbach" <kurt@linutronix.de>,
"Andrew Lunn" <andrew@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Woojung Huh" <woojung.huh@microchip.com>,
UNGLinuxDriver@microchip.com,
"Claudiu Manoil" <claudiu.manoil@nxp.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Simon Horman" <horms@kernel.org>,
"Richard Cochran" <richardcochran@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: dsa: convert to ndo_hwtstamp_get() and ndo_hwtstamp_set()
Date: Thu, 8 May 2025 23:40:59 +0300 [thread overview]
Message-ID: <20250508204059.msdda5kll4s7coti@skbuf> (raw)
In-Reply-To: <21e9e805-1582-4960-8250-61fe47b2d0aa@linux.dev>
On Thu, May 08, 2025 at 09:25:14PM +0100, Vadim Fedorenko wrote:
> The new interface also supports providing error explanation via extack,
> it would be great to add some error messages in case when setter fails.
> For example, HIRSCHMANN HellCreek switch doesn't support disabling
> of timestamps, it's not obvious from general -ERANGE error code, but can
> be explained by the text in extack message.
I wanted to keep the patches spartan and not lose track of the conversion
subtleties in embelishments like extack messages which can be added later
and do not require nearly as much attention to the flow before and after.
I'm afraid if I say "yes" here to the request to add extack to hellcreek
I'm opening the door to further requests to do that for other DSA drivers,
and sadly I do not have infinite time to fulfill them. Plus, I would
like to finalize the conversion tree-wide by the end of this development
cycle.
Even if I were to follow through with your request, I would do so in a
separate patch. I've self-reviewed this patch prior to posting it, and I
was already of the impression that it is pretty busy as it is.
next prev parent reply other threads:[~2025-05-08 20:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-08 9:52 [PATCH net-next] net: dsa: convert to ndo_hwtstamp_get() and ndo_hwtstamp_set() Vladimir Oltean
2025-05-08 20:25 ` Vadim Fedorenko
2025-05-08 20:40 ` Vladimir Oltean [this message]
2025-05-08 20:48 ` Vadim Fedorenko
2025-05-08 20:56 ` Vladimir Oltean
2025-05-08 22:15 ` Vadim Fedorenko
2025-05-09 23:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250508204059.msdda5kll4s7coti@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=vadim.fedorenko@linux.dev \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox