netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Byungchul Park <byungchul@sk.com>
To: willy@infradead.org, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	kernel_team@skhynix.com, kuba@kernel.org, almasrymina@google.com,
	ilias.apalodimas@linaro.org, harry.yoo@oracle.com,
	hawk@kernel.org, akpm@linux-foundation.org, ast@kernel.org,
	daniel@iogearbox.net, davem@davemloft.net,
	john.fastabend@gmail.com, andrew+netdev@lunn.ch,
	edumazet@google.com, pabeni@redhat.com, vishal.moola@gmail.com
Subject: [RFC 06/19] page_pool: rename page_pool_return_page() to page_pool_return_netmem()
Date: Fri,  9 May 2025 20:51:13 +0900	[thread overview]
Message-ID: <20250509115126.63190-7-byungchul@sk.com> (raw)
In-Reply-To: <20250509115126.63190-1-byungchul@sk.com>

Now that page_pool_return_page() is for returning netmem, not struct
page, rename it to page_pool_return_netmem() to reflect what it does.

Signed-off-by: Byungchul Park <byungchul@sk.com>
---
 net/core/page_pool.c | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/net/core/page_pool.c b/net/core/page_pool.c
index 57ad133e6dc8c..bd43026ed7232 100644
--- a/net/core/page_pool.c
+++ b/net/core/page_pool.c
@@ -374,7 +374,7 @@ struct page_pool *page_pool_create(const struct page_pool_params *params)
 }
 EXPORT_SYMBOL(page_pool_create);
 
-static void page_pool_return_page(struct page_pool *pool, netmem_ref netmem);
+static void page_pool_return_netmem(struct page_pool *pool, netmem_ref netmem);
 
 static noinline netmem_ref page_pool_refill_alloc_cache(struct page_pool *pool)
 {
@@ -412,7 +412,7 @@ static noinline netmem_ref page_pool_refill_alloc_cache(struct page_pool *pool)
 			 * (2) break out to fallthrough to alloc_pages_node.
 			 * This limit stress on page buddy alloactor.
 			 */
-			page_pool_return_page(pool, netmem);
+			page_pool_return_netmem(pool, netmem);
 			alloc_stat_inc(pool, waive);
 			netmem = 0;
 			break;
@@ -679,7 +679,7 @@ static __always_inline void __page_pool_release_page_dma(struct page_pool *pool,
  * a regular page (that will eventually be returned to the normal
  * page-allocator via put_page).
  */
-void page_pool_return_page(struct page_pool *pool, netmem_ref netmem)
+static void page_pool_return_netmem(struct page_pool *pool, netmem_ref netmem)
 {
 	int count;
 	bool put;
@@ -796,7 +796,7 @@ __page_pool_put_page(struct page_pool *pool, netmem_ref netmem,
 	 * will be invoking put_page.
 	 */
 	recycle_stat_inc(pool, released_refcnt);
-	page_pool_return_page(pool, netmem);
+	page_pool_return_netmem(pool, netmem);
 
 	return 0;
 }
@@ -835,7 +835,7 @@ void page_pool_put_unrefed_netmem(struct page_pool *pool, netmem_ref netmem,
 	if (netmem && !page_pool_recycle_in_ring(pool, netmem)) {
 		/* Cache full, fallback to free pages */
 		recycle_stat_inc(pool, ring_full);
-		page_pool_return_page(pool, netmem);
+		page_pool_return_netmem(pool, netmem);
 	}
 }
 EXPORT_SYMBOL(page_pool_put_unrefed_netmem);
@@ -878,7 +878,7 @@ static void page_pool_recycle_ring_bulk(struct page_pool *pool,
 	 * since put_page() with refcnt == 1 can be an expensive operation.
 	 */
 	for (; i < bulk_len; i++)
-		page_pool_return_page(pool, bulk[i]);
+		page_pool_return_netmem(pool, bulk[i]);
 }
 
 /**
@@ -961,7 +961,7 @@ static netmem_ref page_pool_drain_frag(struct page_pool *pool,
 		return netmem;
 	}
 
-	page_pool_return_page(pool, netmem);
+	page_pool_return_netmem(pool, netmem);
 	return 0;
 }
 
@@ -975,7 +975,7 @@ static void page_pool_free_frag(struct page_pool *pool)
 	if (!netmem || page_pool_unref_netmem(netmem, drain_count))
 		return;
 
-	page_pool_return_page(pool, netmem);
+	page_pool_return_netmem(pool, netmem);
 }
 
 netmem_ref page_pool_alloc_frag_netmem(struct page_pool *pool,
@@ -1042,7 +1042,7 @@ static void page_pool_empty_ring(struct page_pool *pool)
 			pr_crit("%s() page_pool refcnt %d violation\n",
 				__func__, netmem_ref_count(netmem));
 
-		page_pool_return_page(pool, netmem);
+		page_pool_return_netmem(pool, netmem);
 	}
 }
 
@@ -1075,7 +1075,7 @@ static void page_pool_empty_alloc_cache_once(struct page_pool *pool)
 	 */
 	while (pool->alloc.count) {
 		netmem = pool->alloc.cache[--pool->alloc.count];
-		page_pool_return_page(pool, netmem);
+		page_pool_return_netmem(pool, netmem);
 	}
 }
 
@@ -1194,7 +1194,7 @@ void page_pool_update_nid(struct page_pool *pool, int new_nid)
 	/* Flush pool alloc cache, as refill will check NUMA node */
 	while (pool->alloc.count) {
 		netmem = pool->alloc.cache[--pool->alloc.count];
-		page_pool_return_page(pool, netmem);
+		page_pool_return_netmem(pool, netmem);
 	}
 }
 EXPORT_SYMBOL(page_pool_update_nid);
-- 
2.17.1


  parent reply	other threads:[~2025-05-09 11:51 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-09 11:51 [RFC 00/19] Split netmem from struct page Byungchul Park
2025-05-09 11:51 ` [RFC 01/19] netmem: rename struct net_iov to struct netmem_desc Byungchul Park
2025-05-12 13:11   ` Pavel Begunkov
2025-05-12 13:29     ` Byungchul Park
2025-05-12 19:14       ` Mina Almasry
2025-05-13  2:00         ` Byungchul Park
2025-05-13 12:58           ` Pavel Begunkov
2025-05-13 12:49       ` Pavel Begunkov
2025-05-14  0:07         ` Byungchul Park
2025-05-09 11:51 ` [RFC 02/19] netmem: introduce netmem alloc/put API to wrap page alloc/put API Byungchul Park
2025-05-09 13:39   ` Mina Almasry
2025-05-09 14:08     ` Mina Almasry
2025-05-12 12:30       ` Byungchul Park
2025-05-09 11:51 ` [RFC 03/19] page_pool: use netmem alloc/put API in __page_pool_alloc_page_order() Byungchul Park
2025-05-09 11:51 ` [RFC 04/19] page_pool: rename __page_pool_alloc_page_order() to __page_pool_alloc_large_netmem() Byungchul Park
2025-05-09 11:51 ` [RFC 05/19] page_pool: use netmem alloc/put API in __page_pool_alloc_pages_slow() Byungchul Park
2025-05-09 11:51 ` Byungchul Park [this message]
2025-05-09 11:51 ` [RFC 07/19] page_pool: use netmem alloc/put API in page_pool_return_netmem() Byungchul Park
2025-05-09 11:51 ` [RFC 08/19] page_pool: rename __page_pool_release_page_dma() to __page_pool_release_netmem_dma() Byungchul Park
2025-05-09 11:51 ` [RFC 09/19] page_pool: rename __page_pool_put_page() to __page_pool_put_netmem() Byungchul Park
2025-05-09 11:51 ` [RFC 10/19] page_pool: rename __page_pool_alloc_pages_slow() to __page_pool_alloc_netmems_slow() Byungchul Park
2025-05-09 11:51 ` [RFC 11/19] mlx4: use netmem descriptor and API for page pool Byungchul Park
2025-05-09 11:51 ` [RFC 12/19] netmem: introduce page_pool_recycle_direct_netmem() Byungchul Park
2025-05-09 11:51 ` [RFC 13/19] page_pool: expand scope of is_pp_{netmem,page}() to global Byungchul Park
2025-05-12 12:46   ` Toke Høiland-Jørgensen
2025-05-12 12:55     ` Byungchul Park
2025-05-14  3:00     ` Byungchul Park
2025-05-14 11:17       ` Toke Høiland-Jørgensen
2025-05-09 11:51 ` [RFC 14/19] mm: page_alloc: do not directly access page->pp_magic but use is_pp_page() Byungchul Park
2025-05-09 11:51 ` [RFC 15/19] mlx5: use netmem descriptor and API for page pool Byungchul Park
2025-05-09 11:51 ` [RFC 16/19] netmem: use _Generic to cover const casting for page_to_netmem() Byungchul Park
2025-05-09 11:51 ` [RFC 17/19] netmem: remove __netmem_get_pp() Byungchul Park
2025-05-09 13:47   ` Mina Almasry
2025-05-09 11:51 ` [RFC 18/19] page_pool: make page_pool_get_dma_addr() just wrap page_pool_get_dma_addr_netmem() Byungchul Park
2025-05-09 13:49   ` Mina Almasry
2025-05-10  7:28   ` Ilias Apalodimas
2025-05-09 11:51 ` [RFC 19/19] mm, netmem: remove the page pool members in struct page Byungchul Park
2025-05-09 17:32   ` Mina Almasry
2025-05-09 18:11     ` Matthew Wilcox
2025-05-09 19:04       ` Mina Almasry
2025-05-09 19:48         ` Matthew Wilcox
2025-05-12 19:10           ` Mina Almasry
2025-05-09 18:02   ` Matthew Wilcox
2025-05-12 12:51     ` Byungchul Park
2025-05-12 14:42       ` Matthew Wilcox
2025-05-13  1:42         ` Byungchul Park
2025-05-13  3:19           ` Matthew Wilcox
2025-05-13 10:24             ` Byungchul Park
2025-05-10  7:26   ` Ilias Apalodimas
2025-05-12 12:58     ` Byungchul Park
2025-05-09 14:09 ` [RFC 00/19] Split netmem from " Mina Almasry
2025-05-12 12:36   ` Byungchul Park
2025-05-12 12:59     ` Pavel Begunkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250509115126.63190-7-byungchul@sk.com \
    --to=byungchul@sk.com \
    --cc=akpm@linux-foundation.org \
    --cc=almasrymina@google.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=ast@kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=harry.yoo@oracle.com \
    --cc=hawk@kernel.org \
    --cc=ilias.apalodimas@linaro.org \
    --cc=john.fastabend@gmail.com \
    --cc=kernel_team@skhynix.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=vishal.moola@gmail.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).