From: Jakub Kicinski <kuba@kernel.org>
To: Edward Cree <ecree.xilinx@gmail.com>
Cc: Gal Pressman <gal@nvidia.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
netdev@vger.kernel.org, Simon Horman <horms@kernel.org>,
Andrew Lunn <andrew@lunn.ch>, Tariq Toukan <tariqt@nvidia.com>
Subject: Re: [PATCH net-next v2] ethtool: Block setting of symmetric RSS when non-symmetric rx-flow-hash is requested
Date: Fri, 9 May 2025 16:28:02 -0700 [thread overview]
Message-ID: <20250509162802.54bcfb5a@kernel.org> (raw)
In-Reply-To: <a0a458de-44b4-4f08-b6d4-4775212c1cf0@gmail.com>
On Thu, 8 May 2025 15:41:39 +0100 Edward Cree wrote:
> On 08/05/2025 11:30, Gal Pressman wrote:
> > The conversion of uapi #defines to enum is not ideal, but as Jakub
> > mentioned [1], we have precedent for that.
> >
> > [1] https://lore.kernel.org/netdev/20250324073509.6571ade3@kernel.org/
>
> Isn't the traditional solution to this kind of issue to do
> #define FOO FOO
> after each enumeration constant definition?
> Any reason that can't be done here?
I think the question is reverted. Any reason to do it here when we have
no proof that code using ifdef CONSTANT exists..
As previously mentioned there's precedent for define -> enum conversions
for BTF, and nobody complained. OTOH having each line followed by a
define is not super clean.
next prev parent reply other threads:[~2025-05-09 23:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-08 10:30 [PATCH net-next v2] ethtool: Block setting of symmetric RSS when non-symmetric rx-flow-hash is requested Gal Pressman
2025-05-08 14:41 ` Edward Cree
2025-05-09 23:28 ` Jakub Kicinski [this message]
2025-05-09 23:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250509162802.54bcfb5a@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).