From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D73224BBE1 for ; Mon, 12 May 2025 17:22:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747070523; cv=none; b=a6HPUrK/sIVir6bG1HKeKKz9ygXQeDwa4tj/s5kkdX1pgHeZAJa8oKzT4Th3vifTANwoZFFNFI/PSTp8DyNP6gx3DP+5SQ8im62kLPYKlG9SUD2MpyGs285R/rkwlGeeir7Y+BFyRkPikD8TW6zAks/ncchQh9tnVBV0APDRbCM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747070523; c=relaxed/simple; bh=soJO4A4AjQPFXEEm8Vly+9M2b9nOAfW43rupkSUMSm8=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=giMYwL6PgGtztloUWNOfPuPzRG3JOzQVhgy5p4CNBxFoUbS6VytotXj35apGhZ8aBAg61ldHFUaN53eWB5Djm7WF6H/RtE1D2wCWIBmky7illDdx/57gETfP4+DUHjhThybehJ64uTuPY3E9rriMAR26NNfD1FbfOE1eRlxhqo0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=H800bMg9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="H800bMg9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 01D2DC4CEE7; Mon, 12 May 2025 17:22:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747070522; bh=soJO4A4AjQPFXEEm8Vly+9M2b9nOAfW43rupkSUMSm8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=H800bMg9hqnv8v4VunViEWyxpF50Txz38vqJV4wqjgqkT2GMc+bvhjjfbDC3MQy6m Km+rrH7e3IAP1TXIkFgg2lhUj8Km6xdpcPjsJJpr8Tb8LQ6RGLKXThqMgr5KG5gBRH nJNNeqd3U9ltFLsSyXfiTUt3vQPR6oDCiVpCORJog11+UHcE8hLnl9UFGvGwkhDSRq F+4HQfrDryePQ7z4LGqJejC5OPcKaJNLayof8ygKBMpPIeOotQt04MepQQRGJVtcsj QoI8bVW24RVdRcmz4R9eCXWwMPffw6ZnG9mxSHshIZBfwVkMNg4jBnBudov/2XHGku a1oJc3O8R/vnw== Date: Mon, 12 May 2025 10:22:01 -0700 From: Jakub Kicinski To: Vladimir Oltean Cc: netdev@vger.kernel.org, Maxime Coquelin , Alexandre Torgue , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Russell King , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Vadim Fedorenko , Richard Cochran , Furong Xu <0x1207@gmail.com> Subject: Re: [PATCH net-next] net: stmmac: convert to ndo_hwtstamp_get() and ndo_hwtstamp_set() Message-ID: <20250512102201.01a695c4@kernel.org> In-Reply-To: <20250512143607.595490-1-vladimir.oltean@nxp.com> References: <20250512143607.595490-1-vladimir.oltean@nxp.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 12 May 2025 17:36:07 +0300 Vladimir Oltean wrote: > - netdev_alert(priv->dev, "No support for HW time stamping\n"); > + NL_SET_ERR_MSG_MOD(extack, "No support for HW time stamping\n"); coccinelle says: drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:594:29-64: WARNING avoid newline at end of message in NL_SET_ERR_MSG_MOD Feel free to repost without the 24h wait. -- pw-bot: cr