[PATCH net-next] net: txgbe: Fix pending interrupt

[PATCH net-next] net: txgbe: Fix pending interrupt

[Jiawen Wu]

For unknown reasons, sometimes the value of MISC interrupt is 0 in the
IRQ handle function. In this case, wx_intr_enable() is also should be
invoked to clear the interrupt. Otherwise, the next interrupt would
never be reported.

Fixes: a9843689e2de ("net: txgbe: add sriov function support")
Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
---
 drivers/net/ethernet/wangxun/txgbe/txgbe_irq.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/net/ethernet/wangxun/txgbe/txgbe_irq.c b/drivers/net/ethernet/wangxun/txgbe/txgbe_irq.c
index 3b9e831cf0ef..19878f02d956 100644
--- a/drivers/net/ethernet/wangxun/txgbe/txgbe_irq.c
+++ b/drivers/net/ethernet/wangxun/txgbe/txgbe_irq.c
@@ -112,8 +112,6 @@ static irqreturn_t txgbe_misc_irq_handle(int irq, void *data)
 
 	if (wx->pdev->msix_enabled) {
 		eicr = wx_misc_isb(wx, WX_ISB_MISC);
-		if (!eicr)
-			return IRQ_NONE;
 		txgbe->eicr = eicr;
 		if (eicr & TXGBE_PX_MISC_IC_VF_MBOX) {
 			wx_msg_task(txgbe->wx);
@@ -139,10 +137,7 @@ static irqreturn_t txgbe_misc_irq_handle(int irq, void *data)
 	q_vector = wx->q_vector[0];
 	napi_schedule_irqoff(&q_vector->napi);
 
-	eicr = wx_misc_isb(wx, WX_ISB_MISC);
-	if (!eicr)
-		return IRQ_NONE;
-	txgbe->eicr = eicr;
+	txgbe->eicr = wx_misc_isb(wx, WX_ISB_MISC);
 
 	return IRQ_WAKE_THREAD;
 }
-- 
2.48.1

Re: [PATCH net-next] net: txgbe: Fix pending interrupt

[Simon Horman]

On Mon, May 12, 2025 at 06:06:52PM +0800, Jiawen Wu wrote:
> For unknown reasons, sometimes the value of MISC interrupt is 0 in the
> IRQ handle function. In this case, wx_intr_enable() is also should be
> invoked to clear the interrupt. Otherwise, the next interrupt would
> never be reported.
> 
> Fixes: a9843689e2de ("net: txgbe: add sriov function support")
> Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>

Reviewed-by: Simon Horman <horms@kernel.org>

Re: [PATCH net-next] net: txgbe: Fix pending interrupt

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 12 May 2025 18:06:52 +0800 you wrote:
> For unknown reasons, sometimes the value of MISC interrupt is 0 in the
> IRQ handle function. In this case, wx_intr_enable() is also should be
> invoked to clear the interrupt. Otherwise, the next interrupt would
> never be reported.
> 
> Fixes: a9843689e2de ("net: txgbe: add sriov function support")
> Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
> 
> [...]

Here is the summary with links:
  - [net-next] net: txgbe: Fix pending interrupt
    https://git.kernel.org/netdev/net-next/c/904c6ad822b6

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html