From: Leon Romanovsky <leon@kernel.org>
To: ALOK TIWARI <alok.a.tiwari@oracle.com>
Cc: Konstantin Taranov <kotaranov@linux.microsoft.com>,
kotaranov@microsoft.com, pabeni@redhat.com,
haiyangz@microsoft.com, kys@microsoft.com, edumazet@google.com,
kuba@kernel.org, davem@davemloft.net, decui@microsoft.com,
wei.liu@kernel.org, longli@microsoft.com, jgg@ziepe.ca,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH rdma-next v4 4/4] net: mana: Add support for auxiliary device servicing events
Date: Mon, 12 May 2025 14:32:48 +0300 [thread overview]
Message-ID: <20250512113248.GE22843@unreal> (raw)
In-Reply-To: <01f27ba0-6239-4195-beda-bc3fea1a30cf@oracle.com>
On Mon, May 12, 2025 at 10:59:43AM +0530, ALOK TIWARI wrote:
>
>
> On 07-05-2025 21:29, Konstantin Taranov wrote:
> > From: Shiraz Saleem <shirazsaleem@microsoft.com>
> >
> > Handle soc servcing events which require the rdma auxiliary device resources to
>
> typo servcing ->servicing
<...>
> > + val = service_data.value;
>
> what is use of val?
>
<...>
> > +static void mana_handle_rdma_servicing(struct work_struct *work)
>
> this name does not sound clearer and more aligned with typical naming
> conventions.
> Since it is an RDMA service event handler, it could be named to
> mana_rdma_service_handle. What are your thoughts on this?"
I fixed all these comments locally when applied the series.
Thank you for the review.
next prev parent reply other threads:[~2025-05-12 11:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-07 15:59 [PATCH rdma-next v4 0/4] RDMA/mana_ib: allow separate mana_ib for each mana client Konstantin Taranov
2025-05-07 15:59 ` [PATCH rdma-next v4 1/4] net: mana: Probe rdma device in mana driver Konstantin Taranov
2025-05-11 18:16 ` Long Li
2025-05-07 15:59 ` [PATCH rdma-next v4 2/4] RDMA/mana_ib: Add support of mana_ib for RNIC and ETH nic Konstantin Taranov
2025-05-11 18:19 ` Long Li
2025-05-07 15:59 ` [PATCH rdma-next v4 3/4] RDMA/mana_ib: unify mana_ib functions to support any gdma device Konstantin Taranov
2025-05-11 18:30 ` Long Li
2025-05-07 15:59 ` [PATCH rdma-next v4 4/4] net: mana: Add support for auxiliary device servicing events Konstantin Taranov
2025-05-12 5:29 ` ALOK TIWARI
2025-05-12 11:32 ` Leon Romanovsky [this message]
2025-05-12 10:45 ` [PATCH rdma-next v4 0/4] RDMA/mana_ib: allow separate mana_ib for each mana client Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250512113248.GE22843@unreal \
--to=leon@kernel.org \
--cc=alok.a.tiwari@oracle.com \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=edumazet@google.com \
--cc=haiyangz@microsoft.com \
--cc=jgg@ziepe.ca \
--cc=kotaranov@linux.microsoft.com \
--cc=kotaranov@microsoft.com \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).