From: Simon Horman <horms@kernel.org>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Shuah Khan <shuah@kernel.org>,
Matthieu Baerts <matttbe@kernel.org>,
Mat Martineau <martineau@kernel.org>,
Geliang Tang <geliang@kernel.org>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Jozsef Kadlecsik <kadlec@netfilter.org>,
Andrea Mayer <andrea.mayer@uniroma2.it>,
Paolo Lungaroni <paolo.lungaroni@uniroma2.it>,
linux-kselftest@vger.kernel.org, mptcp@lists.linux.dev,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org
Subject: Re: [PATCHv2 net-next 1/6] selftests: net: disable rp_filter after namespace initialization
Date: Mon, 12 May 2025 17:04:21 +0100 [thread overview]
Message-ID: <20250512160421.GO3339421@horms.kernel.org> (raw)
In-Reply-To: <20250508081910.84216-2-liuhangbin@gmail.com>
On Thu, May 08, 2025 at 08:19:05AM +0000, Hangbin Liu wrote:
> Some distributions enable rp_filter globally by default. To ensure consistent
> behavior across environments, we explicitly disable it in several test cases.
>
> This patch moves the rp_filter disabling logic to immediately after the
> network namespace is initialized. With this change, individual test cases
> with creating namespace via setup_ns no longer need to disable rp_filter
> again.
>
> This helps avoid redundancy and ensures test consistency.
>
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-05-12 16:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-08 8:19 [PATCHv2 net-next 0/6] selftests: net: configure rp_filter in setup_ns Hangbin Liu
2025-05-08 8:19 ` [PATCHv2 net-next 1/6] selftests: net: disable rp_filter after namespace initialization Hangbin Liu
2025-05-12 16:04 ` Simon Horman [this message]
2025-05-08 8:19 ` [PATCHv2 net-next 2/6] selftests: net: remove redundant rp_filter configuration Hangbin Liu
2025-05-12 16:04 ` Simon Horman
2025-05-08 8:19 ` [PATCHv2 net-next 3/6] selftests: net: use setup_ns for bareudp testing Hangbin Liu
2025-05-12 16:04 ` Simon Horman
2025-05-08 8:19 ` [PATCHv2 net-next 4/6] selftests: net: use setup_ns for SRv6 tests and remove rp_filter configuration Hangbin Liu
2025-05-11 1:34 ` Andrea Mayer
2025-05-08 8:19 ` [PATCHv2 net-next 5/6] selftests: netfilter: " Hangbin Liu
2025-05-08 8:19 ` [PATCHv2 net-next 6/6] selftests: mptcp: " Hangbin Liu
2025-05-13 1:20 ` [PATCHv2 net-next 0/6] selftests: net: configure rp_filter in setup_ns patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250512160421.GO3339421@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrea.mayer@uniroma2.it \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geliang@kernel.org \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=martineau@kernel.org \
--cc=matttbe@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=paolo.lungaroni@uniroma2.it \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).